From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Tegra: Split tegra_get_chip_type() into soc & sku funcs
Date: Wed, 10 Apr 2013 12:13:57 -0600 [thread overview]
Message-ID: <5165ABE5.3050707@wwwdotorg.org> (raw)
In-Reply-To: <1365616424-6713-1-git-send-email-twarren@nvidia.com>
On 04/10/2013 11:53 AM, Tom Warren wrote:
> As suggested by Stephen Warren, use tegra_get_chip() to return
> the pure CHIPID for a Tegra SoC (i.e. 0x20 for Tegra20, 0x30 for
> Tegra30, etc.) and rename tegra_get_chip_type() to reflect its true
> function, i.e. tegra_get_chip_sku(), which returns an ID like
> TEGRA_SOC_T25, TEGRA_SOC_T33, etc.
> diff --git a/arch/arm/cpu/arm720t/tegra-common/cpu.c b/arch/arm/cpu/arm720t/tegra-common/cpu.c
> + /* get SOC (chip) type */
> + soc_type = tegra_get_chip();
> + /* adjust PLLP_out1-4 on T3x/T114 */
> + if (soc_type >= CHIPID_TEGRA30) {
In the long run, I doubt >= will work here, since there's probably no
guarantee that newer chips will have larger chipid values. However, it's
fine for the chips we currently support.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
prev parent reply other threads:[~2013-04-10 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 17:53 [U-Boot] [PATCH v2] Tegra: Split tegra_get_chip_type() into soc & sku funcs Tom Warren
2013-04-10 18:13 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5165ABE5.3050707@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.