Re: [Qemu-devel] [RFC PATCH RDMA support v1: 07/13] introduce capability for dynamic chunk registration

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On 04/10/2013 04:28 PM, mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
> 
> This capability allows you to disable dynamic chunk registration
> for better throughput on high-performance links.
> 
> It is enabled by default.

Actually, it isn't enabled until 8/13 - I'd squash 7 and 8 together, to
make this statement true.

> +++ b/qapi-schema.json
> @@ -602,7 +602,7 @@
>  # Since: 1.2

Missing documentation of the new capability.  Should look something like:

# @chunk-register-destination: Migration does XYZ on the destination.
#                              Enabled by default (since 1.5)

>  ##
>  { 'enum': 'MigrationCapability',
> -  'data': ['xbzrle'] }
> +  'data': ['xbzrle', 'chunk_register_destination'] }

QMP prefers '-' over '_'/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]