All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT_FILTERKEYs
Date: Thu, 11 Apr 2013 11:43:29 +0800	[thread overview]
Message-ID: <51663161.9070300@asianux.com> (raw)
In-Reply-To: <803399362.12318964.1365629578422.JavaMail.root@redhat.com>

On 2013年04月11日 05:32, Eric Paris wrote:
> ----- Original Message -----
>> > 
>> >   also for function audit_list:
>> >     when call audit_make_reply fails (will return NULL).
>> >     we need free all its related variables instead of only kfree rull.
>> >       (such as call autit_free_rule)
>> > 
>> >   please help check, thanks.
> audit_free_rule() takes a struct audit_entry, not an audit_rule. 

  yes. but maybe you misunderstand what I said (excuse me, my English is
not quite weill)
  I said: "need we process the rule just like audit_free_rule has done ?"


> struct audit_rule does not have additional things which need to be freed...
> 
> 

  oh, it is my fault:
    (I did not notice: rule is struct audit_rule, not struct audit_krule).

  thanks.

  :-)

-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-04-11  3:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10  9:52 [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT_FILTERKEYs Chen Gang
2013-04-10 10:18 ` Chen Gang
2013-04-10 10:28   ` Chen Gang
2013-04-10 10:36     ` Chen Gang
2013-04-10 21:38       ` Eric Paris
2013-04-11  1:12         ` Chen Gang
2013-04-10 21:32     ` Eric Paris
2013-04-11  3:43       ` Chen Gang [this message]
2013-04-10 20:29   ` Eric Paris
2013-04-11  3:55     ` Chen Gang
2013-04-10 21:19   ` Eric Paris
2013-04-11  4:10     ` Chen Gang
2013-04-11 13:40       ` Eric Paris
2013-04-11 14:34         ` Chen Gang
2013-04-11 14:52           ` Chen Gang
2013-04-12  9:42       ` Chen Gang
2013-04-16 10:25         ` Chen Gang
2013-04-16 10:38           ` Chen Gang
2013-04-17  2:41             ` Chen Gang
2013-04-17  4:23               ` [PATCH v2] kernel: auditfilter: resource management, tree and watch will memory leak when failure occurs Chen Gang
2013-04-10 20:08 ` [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT_FILTERKEYs Eric Paris
2013-04-11  3:56   ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51663161.9070300@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.