Re: [PATCH 2/2] Btrfs: make some functions return type be void in backref.c

[Wang Shilong <wangsl-fnst@cn.fujitsu.com>]

Hello, David

Patch V2 has been sent out,many thanks for your review ^_^

Thanks,
Wang

> On Wed, Apr 10, 2013 at 07:22:51PM +0800, Wang Shilong wrote:
>> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
>>
>> __merge_refs() and __add_missing_keys() always return 0, it is unnecessary
>> for the caller to check the return value.
> 
> ok for __merge_refs, nak for __add_missing_keys: there's unhandled
> BUG_ON from read_tree_block
> 
>  422                 eb = read_tree_block(fs_info->tree_root, ref->wanted_disk_byte,
>  423                                      fs_info->tree_root->leafsize, 0);
>  424                 BUG_ON(!eb);
> 
> this should become a proper error handling someday and use the int return
> value. Keep the callers aware of that.
> 
> david
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>