All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Mylene Josserand <Mylene.Josserand@navocap.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [imx27 - mcp251x] MCP251x does not work in static ?
Date: Thu, 11 Apr 2013 10:39:17 +0200	[thread overview]
Message-ID: <516676B5.6090903@pengutronix.de> (raw)
In-Reply-To: <CA78C307B8F06747967D122FC656B15377445D@SERVEUR0.nvp.local>

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

On 04/11/2013 10:04 AM, Mylene Josserand wrote:
>>> root@navocap:~# ifconfig can0 up
>>> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 201
>>> mcp251x spi0.0: failed to acquire irq 201
>>
>> It's a bug in the driver....which was introduced in v3.5[1]. I'm looking
>> for a fix.
>>
>> Marc
>>
>> [1] 1c6c695 genirq: Reject bogus threaded irq requests
>>
> 
> Okay.
> 
> In this
> http://markmail.org/thread/uc2adurel247yitp#query:+page:1+mid:uc2adurel247yitp+state:results 
> and this 
> http://www.raspberrypi.org/phpBB3/viewtopic.php?f=44&t=7027&start=150 
> posts, they set the irq_flags to IRQF_ONESHOT.
> 
> I have tested it and I did not have the error anymore. Maybe it is not a 
> good way to fix that ? (I don't know what is a "one shot" IRQ) but in 
> case it could help.
> However, it did not fix my static-mcp251x boot hang.

Can you test my patch and give me a Tested-by?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-04-11  8:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 13:07 [imx27 - mcp251x] MCP251x does not work in static ? Mylene Josserand
2013-04-10 13:39 ` Marc Kleine-Budde
2013-04-10 14:11   ` Mylene Josserand
2013-04-10 15:30     ` Marc Kleine-Budde
2013-04-11  7:39       ` Mylene Josserand
2013-04-11  7:49         ` Marc Kleine-Budde
2013-04-11  8:04           ` Mylene Josserand
2013-04-11  8:39             ` Marc Kleine-Budde [this message]
2013-04-11  9:22               ` Mylene Josserand
2013-04-11  9:49                 ` Marc Kleine-Budde
2013-04-11 14:39                   ` Mylene Josserand
2013-04-11 15:09                     ` Marc Kleine-Budde
2013-04-12  9:24                       ` Mylene Josserand
2013-04-12  9:49                         ` Marc Kleine-Budde
2013-04-12  9:36                     ` Marc Kleine-Budde
2013-04-12  9:40                       ` Mylene Josserand
2013-04-12  9:48                         ` Marc Kleine-Budde
2013-04-11  8:36           ` RFC: [PATCH] can: mcp251x: add missing IRQF_ONESHOT to request_threaded_irq Marc Kleine-Budde
2013-04-12 11:16             ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516676B5.6090903@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Mylene.Josserand@navocap.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.