From: Paolo Bonzini <pbonzini@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org,
Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener
Date: Thu, 11 Apr 2013 15:14:19 +0200 [thread overview]
Message-ID: <5166B72B.5040704@redhat.com> (raw)
In-Reply-To: <CAJnKYQ=naRTBCnRXJcXTFBfDUQ2YMzvoFO_HeAbCG-LMW=fJPQ@mail.gmail.com>
Il 11/04/2013 14:08, liu ping fan ha scritto:
>>> >> /* clean up network at qemu process termination */
>>> >> atexit(&net_cleanup);
>>> >> + atexit(&hostmem_finalize);
>> >
>> > This should be in hostmem_init.
>> >
> Ok, thanks. And extra, for the hostmem_init, what about something like
> #define block_init(function) module_init(function, MODULE_INIT_BLOCK)
Actually, I would prefer that you do not use a global, so the above
comment doesn't really apply unless someone overrides me and tell you to
use a global.
Paolo
next prev parent reply other threads:[~2013-04-11 13:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 8:20 [Qemu-devel] [PATCH 0/5] proposal to make hostmem listener RAM unplug safe Liu Ping Fan
2013-04-01 8:20 ` [Qemu-devel] [PATCH 1/5] memory: add ref/unref interface for MemroyRegionOps Liu Ping Fan
2013-04-11 9:49 ` Stefan Hajnoczi
2013-04-12 4:12 ` liu ping fan
2013-04-01 8:20 ` [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe Liu Ping Fan
2013-04-02 6:11 ` li guang
2013-04-11 10:09 ` Paolo Bonzini
2013-04-12 6:46 ` liu ping fan
2013-04-12 8:21 ` Stefan Hajnoczi
2013-04-11 10:11 ` Stefan Hajnoczi
2013-04-11 10:26 ` Paolo Bonzini
2013-04-12 3:55 ` liu ping fan
2013-04-12 8:38 ` Stefan Hajnoczi
2013-04-12 10:03 ` Paolo Bonzini
2013-04-15 1:42 ` liu ping fan
2013-04-15 6:38 ` Paolo Bonzini
2013-04-01 8:20 ` [Qemu-devel] [PATCH 3/5] vring: use hostmem's RAM safe api Liu Ping Fan
2013-04-11 10:15 ` Stefan Hajnoczi
2013-04-12 4:49 ` liu ping fan
2013-04-12 8:41 ` Stefan Hajnoczi
2013-04-01 8:20 ` [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion Liu Ping Fan
2013-04-02 5:58 ` li guang
2013-04-12 4:44 ` liu ping fan
2013-04-11 10:20 ` Stefan Hajnoczi
2013-04-12 4:48 ` liu ping fan
2013-04-12 8:45 ` Stefan Hajnoczi
2013-04-12 9:05 ` liu ping fan
2013-04-16 7:57 ` Stefan Hajnoczi
2013-04-16 8:12 ` Paolo Bonzini
2013-04-01 8:20 ` [Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener Liu Ping Fan
2013-04-11 10:02 ` Paolo Bonzini
2013-04-11 12:08 ` liu ping fan
2013-04-11 13:14 ` Paolo Bonzini [this message]
2013-06-13 4:38 ` [Qemu-devel] about atexit() (was: [PATCH 5/5] hostmem: init/finalize hostmem listener) Amos Kong
2013-06-13 8:51 ` liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166B72B.5040704@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.