From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH v5.1 01/12] mini-os/tpm{back, front}: Change shared page ABI Date: Thu, 11 Apr 2013 10:11:31 -0400 Message-ID: <5166C493.6040503@tycho.nsa.gov> References: <1363991313-25481-1-git-send-email-dgdegra@tycho.nsa.gov> <1363991420-25569-1-git-send-email-dgdegra@tycho.nsa.gov> <1365688848.8126.0.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1365688848.8126.0.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Matthew.Fioravante@jhuapl.edu" , "xen-devel@lists.xen.org" , "JBeulich@suse.com" , "konrad.wilk@oracle.com" List-Id: xen-devel@lists.xenproject.org On 04/11/2013 10:00 AM, Ian Campbell wrote: > Is this in the wrong thread and should be in "[PATCH v5 00/12] vTPM > updates for 4.3" as an update to > <1363896689-11086-2-git-send-email-dgdegra@tycho.nsa.gov> ? > Yes, this is an update to that patch and should have also been sent in reply to that thread. > On Fri, 2013-03-22 at 22:30 +0000, Daniel De Graaf wrote: >> This changes the vTPM shared page ABI from a copy of the Xen network >> interface to a single-page interface that better reflects the expected >> behavior of a TPM: only a single request packet can be sent at any given >> time, and every packet sent generates a single response packet. This >> protocol change should also increase efficiency as it avoids mapping and >> unmapping grants when possible. The vtpm xenbus device now requires a >> feature-protocol-v2 node in xenstore to avoid conflicts with existing >> (xen-patched) kernels supporting the old interface. >> >> While the contents of the shared page have been defined to allow packets >> larger than a single page (actually 4088 bytes) by allowing the client >> to add extra grant references, the mapping of these extra references has >> not been implemented; a feature node in xenstore may be used in the >> future to indicate full support for the multi-page protocol. Most uses >> of the TPM should not require this feature. >> >> Signed-off-by: Daniel De Graaf >> Cc: Jan Beulich >> >> --- >> >> Changes from v5: handle xenbus states properly, and keep the old header >> contents intact. >> >> Changes from v4: use feature-protocol-v2 nodes instead of changing the >> device name; add command cancellation support to the protocol. >>