From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo-p05-ob.rzone.de ([81.169.146.182]:15671 "EHLO mo-p05-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935155Ab3DKO25 (ORCPT ); Thu, 11 Apr 2013 10:28:57 -0400 Message-ID: <5166C87B.6040305@jan-o-sch.net> Date: Thu, 11 Apr 2013 16:28:11 +0200 From: Jan Schmidt MIME-Version: 1.0 To: miaox@cn.fujitsu.com CC: Linux Btrfs , mfasheh@suse.de Subject: Re: [PATCH] Btrfs-progs: don't set INCOMPAT_EXTENDED_IREF flag when making a new fs References: <51669069.50207@cn.fujitsu.com> In-Reply-To: <51669069.50207@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, April 11, 2013 at 12:28 (+0200), Miao Xie wrote: > There is no extended irefs in the new fs, and we can mount it on > the old kernel without extended iref function safely. So we needn't > set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set > it when we actually insert a extended iref. > > Signed-off-by: Miao Xie > Cc: Mark Fasheh > --- > mkfs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mkfs.c b/mkfs.c > index c8cb395..aca6e46 100644 > --- a/mkfs.c > +++ b/mkfs.c > @@ -1654,8 +1654,6 @@ raid_groups: > > super = root->fs_info->super_copy; > flags = btrfs_super_incompat_flags(super); > - flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF; > - > if (mixed) > flags |= BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS; > > This one should have a large *** do not apply until kernel patches from "[PATCH 0/2] do not open the extend *** inode reference at the beginning" have been merged. tag. Otherwise, extended irefs are disabled entirely for all new file systems in environments where they have been working so far. -Jan