From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQL0O-0002Tj-LX for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQL0N-00081V-Q3 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:09:48 -0400 Received: from mail-bk0-x22f.google.com ([2a00:1450:4008:c01::22f]:34855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQL0N-00081I-Jg for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:09:47 -0400 Received: by mail-bk0-f47.google.com with SMTP id ik5so937030bkc.20 for ; Thu, 11 Apr 2013 10:09:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5166EE54.8040001@redhat.com> Date: Thu, 11 Apr 2013 19:09:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365696633-30727-1-git-send-email-pbonzini@redhat.com> <1365696633-30727-13-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, mst@redhat.com Il 11/04/2013 18:28, Peter Maydell ha scritto: > On 11 April 2013 17:10, Paolo Bonzini wrote: >> > Signed-off-by: Paolo Bonzini > This doesn't look right. The MemoryRegion system isn't > hw-specific, it's a part of the basic QEMU emulation > system which provides functionality to hw/ and other > things (like cputlb.c). The accelerator- and target-independent parts of the basic emulation are already in hw/core (not much really, but consider that CPUs are device and depend on hw/core/qdev.c). The memory API is simply the interface between the accelerators and hw/ (boards & device models). In fact, apart from large parts of exec.c which are really part of the memory API implementation (but I'm not moving it in this patch for simplicity), the other users of the memory API are really the accelerators. KVM and Xen only use listeners, TCG needs more low-level access in cputlb.c and translate-all.c but that's pretty much it. Paolo