All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"Tim (Xen.org)" <tim@xen.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH 3/9] arm: gic: implement IPIs using SGI mechanism
Date: Thu, 11 Apr 2013 23:40:01 +0100	[thread overview]
Message-ID: <51673BC1.8080903@citrix.com> (raw)
In-Reply-To: <1365697065.8126.48.camel@zakaz.uk.xensource.com>

On 04/11/2013 05:17 PM, Ian Campbell wrote:

> @@ -15,17 +16,12 @@ void smp_call_function(
>      void *info,
>      int wait)
>  {
> -    /* TODO: No SMP just now, does not include self so nothing to do.
> -       cpumask_t allbutself = cpu_online_map;
> -       cpu_clear(smp_processor_id(), allbutself);
> -       on_selected_cpus(&allbutself, func, info, wait);
> -    */
> +    panic("%s not implmented\n", __func__);
>  }
> +



Panic calls smp_call_function via machine_halt function.
So, if Xen panics, you will have an infinite loop which writes "%s not
....".
For the moment, I think you should let the function in its current state.
I will try to make a patch to call a function on each CPU with ARM.

Cheers,

Julien

  reply	other threads:[~2013-04-11 22:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  8:52 [PATCH 00/09] arm: host SMP support Ian Campbell
2013-03-06  8:54 ` [PATCH 1/9] arm: initialise VCPU SCTLR in vcpu_initialise Ian Campbell
2013-03-19 15:58   ` Stefano Stabellini
2013-04-11  8:58     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 2/9] arm: consolidate setup of hypervisor traps and second stage paging Ian Campbell
2013-03-19 17:34   ` Stefano Stabellini
2013-04-11  8:58     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 3/9] arm: gic: implement IPIs using SGI mechanism Ian Campbell
2013-03-19 17:28   ` Stefano Stabellini
2013-04-09 14:51     ` Ian Campbell
2013-04-11 15:53       ` Ian Campbell
2013-04-11 16:17       ` Ian Campbell
2013-04-11 22:40         ` Julien Grall [this message]
2013-04-12  8:00           ` Ian Campbell
2013-03-06  8:54 ` [PATCH 4/9] arm64: correct secondary CPU bringup Ian Campbell
2013-04-11  8:27   ` Ian Campbell
2013-04-18 13:33     ` Stefano Stabellini
2013-03-06  8:54 ` [PATCH 5/9] arm: vgic: typo s/securty/security/ Ian Campbell
2013-03-19 16:06   ` Stefano Stabellini
2013-04-11  8:59     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 6/9] arm: vgic: fix race in vgic_vcpu_inject_irq Ian Campbell
2013-03-19 16:10   ` Stefano Stabellini
2013-04-11  8:59     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 7/9] arm: vgic: fix race between evtchn upcall and evtchnop_send Ian Campbell
2013-03-19 16:18   ` Stefano Stabellini
2013-04-09 14:39     ` Ian Campbell
2013-04-11  8:59     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 8/9] arm: gic: fix build on arm64 Ian Campbell
2013-03-19 16:05   ` Stefano Stabellini
2013-04-11  9:00     ` Ian Campbell
2013-03-06  8:54 ` [PATCH 9/9] arm: tweak/improve logging for host SMP Ian Campbell
2013-03-19 16:05   ` Stefano Stabellini
2013-04-11  9:00     ` Ian Campbell
2013-03-22 14:50 ` [PATCH 00/09] arm: host SMP support Stefano Stabellini
2013-03-22 15:05   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51673BC1.8080903@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.