Re: [PATCH] Btrfs-progs: don't set INCOMPAT_EXTENDED_IREF flag when making a new fs

[Miao Xie <miaox@cn.fujitsu.com>]

On Thu, 11 Apr 2013 16:28:11 +0200, Jan Schmidt wrote:
> On Thu, April 11, 2013 at 12:28 (+0200), Miao Xie wrote:
>> There is no extended irefs in the new fs, and we can mount it on
>> the old kernel without extended iref function safely. So we needn't
>> set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set
>> it when we actually insert a extended iref.
>>
>> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
>> Cc: Mark Fasheh <mfasheh@suse.de>
>> ---
>>  mkfs.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/mkfs.c b/mkfs.c
>> index c8cb395..aca6e46 100644
>> --- a/mkfs.c
>> +++ b/mkfs.c
>> @@ -1654,8 +1654,6 @@ raid_groups:
>>  
>>  	super = root->fs_info->super_copy;
>>  	flags = btrfs_super_incompat_flags(super);
>> -	flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF;
>> -
>>  	if (mixed)
>>  		flags |= BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS;
>>  
>>
> 
> This one should have a large
> 
> *** do not apply until kernel patches from "[PATCH 0/2] do not open the extend
> *** inode reference at the beginning" have been merged.
> 
> tag. Otherwise, extended irefs are disabled entirely for all new file systems in
> environments where they have been working so far.

Yes, thanks to point it out.

Miao