From: "Gabriel M. Beddingfield" <gabrbedd@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: ALSA devel <alsa-devel@alsa-project.org>,
Steve Chen <schen@mvista.com>, Stas Sergeev <stsp@list.ru>
Subject: Re: [PATCH] asoc: add dummy codec
Date: Thu, 11 Apr 2013 19:58:40 -0700 [thread overview]
Message-ID: <51677860.7080402@gmail.com> (raw)
In-Reply-To: <5166FAB9.9010506@metafoo.de>
On 04/11/2013 11:02 AM, Lars-Peter Clausen wrote:
>> Instead, wouldn't it be better to extend it by defining some platform data? Maybe something like:
>
> Either you want a dummy or you want one with specific requirements. For the
> former case use the dummy codec, for the later case add a proper driver.
> Putting these kinds of things in your board file is in my opinion a bad habit.
Well, I've seen a couple cases where a dummy codec /is/ the proper
driver and all that's needed is to restrict the formats that the DAI
supports (sample rate, etc).
Yes, we can always write a board-specific dummy codec with the
restricted formats -- but since there's already one in ASoC, why not
make it extensible?
-gabriel
next prev parent reply other threads:[~2013-04-12 2:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 10:36 [PATCH] asoc: add dummy codec Stas Sergeev
2013-04-11 10:41 ` Lars-Peter Clausen
2013-04-11 13:57 ` Stas Sergeev
2013-04-11 14:21 ` Lars-Peter Clausen
2013-04-11 14:33 ` Stas Sergeev
2013-04-11 15:11 ` Stas Sergeev
2013-04-11 15:48 ` Gabriel M. Beddingfield
2013-04-11 16:03 ` Stas Sergeev
2013-04-11 16:13 ` Gabriel M. Beddingfield
2013-04-11 16:44 ` Stas Sergeev
2013-04-11 18:02 ` Lars-Peter Clausen
2013-04-12 2:58 ` Gabriel M. Beddingfield [this message]
2013-04-12 2:50 ` Gabriel M. Beddingfield
2013-04-12 9:09 ` Stas Sergeev
2013-04-11 17:58 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51677860.7080402@gmail.com \
--to=gabrbedd@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=schen@mvista.com \
--cc=stsp@list.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.