All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Rich Johnston <rjohnston@sgi.com>,
	Dave Chinner <dchinner@redhat.com>, xfstests <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: fix the regex pattern in get_group_list of check
Date: Fri, 12 Apr 2013 14:12:35 +0800	[thread overview]
Message-ID: <5167A5D3.4070903@gmail.com> (raw)

In group files, non comment line starts with a 3-digits, then followed by
space and other characters, but no group names.

The old regex in get_group_list uses the group name as part of the regex,
and fails './check -g xfs' run:
         Group "xfs" is empty or not defined?

The patch removes the pattern for group name, and thus we can trigger tests
like "./check -g xfs" as normal.
	

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
  check | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check b/check
index 966fbe5..abc65cb 100755
--- a/check
+++ b/check
@@ -100,7 +100,7 @@ get_group_list()
  		l=$(sed -n < $SRC_DIR/$d/group \
  			-e 's/#.*//' \
  			-e 's/$/ /' \
-			-e "s;\(^[0-9][0-9][0-9]\).* $grp .*;$SRC_DIR/$d/\1;p")
+			-e "s;\(^[0-9][0-9][0-9]\) .*;$SRC_DIR/$d/\1;p")
  		grpl="$grpl $l"
  	done
  	echo $grpl
-- 
1.7.12.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-04-12  6:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12  6:12 Wang Sheng-Hui [this message]
2013-04-12  7:57 ` [PATCH] xfstests: fix the regex pattern in get_group_list of check Dave Chinner
2013-04-12 16:38   ` Wang Sheng-Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5167A5D3.4070903@gmail.com \
    --to=shhuiw@gmail.com \
    --cc=dchinner@redhat.com \
    --cc=rjohnston@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.