From: Chen Gang <gang.chen@asianux.com>
To: Eric Paris <eparis@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: audit_watch: resource management: better reset to NULL.
Date: Fri, 12 Apr 2013 16:18:50 +0800 [thread overview]
Message-ID: <5167C36A.5000700@asianux.com> (raw)
In-Reply-To: <516792A6.9050904@asianux.com>
oh, sorry, this patch is incorrect, please skip it.
On 2013年04月12日 12:50, Chen Gang wrote:
>
> better to set krule->watch = NULL.
> maybe it is not a real issue, but can make code clearer,
> so can help the readers to analyse another issues.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> kernel/audit_watch.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
> index 22831c4..abd8fdb 100644
> --- a/kernel/audit_watch.c
> +++ b/kernel/audit_watch.c
> @@ -456,6 +456,7 @@ void audit_remove_watch_rule(struct audit_krule *krule)
>
> if (list_empty(&watch->rules)) {
> audit_remove_watch(watch);
> + krule->watch = NULL;
>
> if (list_empty(&parent->watches)) {
> audit_get_parent(parent);
>
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-12 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 4:43 [PATCH] kernel: audit_tree: resource management: need put_tree and goto Err when failure occures Chen Gang
2013-04-12 4:50 ` [PATCH] kernel: audit_watch: resource management: better reset to NULL Chen Gang
2013-04-12 8:18 ` Chen Gang [this message]
2013-04-12 8:56 ` [PATCH] kernel: auditfilter: resource management, need process tree when audit_add_watch failed in audit_add_rule Chen Gang
2013-04-17 4:26 ` Chen Gang
2013-04-16 7:35 ` [PATCH] kernel: audit_tree: resource management: need put_tree and goto Err when failure occures Chen Gang
2013-04-17 4:04 ` [PATCH v2] " Chen Gang
2013-04-17 20:07 ` Andrew Morton
2013-04-18 1:19 ` Chen Gang F T
2013-04-20 7:31 ` Chen Gang
2013-04-23 3:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167C36A.5000700@asianux.com \
--to=gang.chen@asianux.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.