From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 12 Apr 2013 10:30:15 +0200 (CEST) Received: from arrakis.dune.hu ([78.24.191.176]:35094 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827479Ab3DLIVuRaKCV (ORCPT ); Fri, 12 Apr 2013 10:21:50 +0200 Received: from arrakis.dune.hu ([127.0.0.1]) by localhost (arrakis.dune.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sb3-ql_cjsgw; Fri, 12 Apr 2013 10:21:03 +0200 (CEST) Received: from [192.168.254.50] (catvpool-576570d8.szarvasnet.hu [87.101.112.216]) by arrakis.dune.hu (Postfix) with ESMTPSA id 60ACE2802BD; Fri, 12 Apr 2013 10:21:03 +0200 (CEST) Message-ID: <5167C439.4090300@openwrt.org> Date: Fri, 12 Apr 2013 10:22:17 +0200 From: Gabor Juhos MIME-Version: 1.0 To: John Crispin CC: Ralf Baechle , linux-mips@linux-mips.org Subject: Re: [PATCH V2 02/16] MIPS: ralink: fix RT305x clock setup References: <1365751663-5725-1-git-send-email-blogic@openwrt.org> <1365751663-5725-2-git-send-email-blogic@openwrt.org> In-Reply-To: <1365751663-5725-2-git-send-email-blogic@openwrt.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 36102 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: juhosg@openwrt.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips 2013.04.12. 9:27 keltezéssel, John Crispin írta: > Add a few missing clocks. > > Signed-off-by: John Crispin > --- > arch/mips/ralink/rt305x.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/ralink/rt305x.c b/arch/mips/ralink/rt305x.c > index 0a4bbdc..64a0336 100644 > --- a/arch/mips/ralink/rt305x.c > +++ b/arch/mips/ralink/rt305x.c > @@ -123,7 +123,8 @@ struct ralink_pinmux gpio_pinmux = { > > void __init ralink_clk_init(void) > { > - unsigned long cpu_rate, sys_rate, wdt_rate, uart_rate; > + unsigned long cpu_rate, sys_rate, wdt_rate, > + uart_rate, wmac_rate = 40000000; Moving the wmac_rate definition into a separate line would make the code more readable. > u32 t = rt_sysc_r32(SYSC_REG_SYSTEM_CONFIG); > > if (soc_is_rt305x() || soc_is_rt3350()) { > @@ -176,11 +177,21 @@ void __init ralink_clk_init(void) > BUG(); > } > > + if (soc_is_rt3352() || soc_is_rt5350()) { > + u32 val = rt_sysc_r32(RT3352_SYSC_REG_SYSCFG0); > + > + if (!(val & RT3352_CLKCFG0_XTAL_SEL)) Given the fact that the definition of RT3352_SYSC_REG_SYSCFG0 and RT3352_CLKCFG0_XTAL_SEL is added in a later patch, this code causes a build error? > + wmac_rate = 20000000; > + } > + > ralink_clk_add("cpu", cpu_rate); > ralink_clk_add("10000b00.spi", sys_rate); > ralink_clk_add("10000100.timer", wdt_rate); > + ralink_clk_add("10000120.watchdog", wdt_rate); > ralink_clk_add("10000500.uart", uart_rate); > ralink_clk_add("10000c00.uartlite", uart_rate); > + ralink_clk_add("10100000.ethernet", sys_rate); > + ralink_clk_add("wmac@10180000", wmac_rate); Should not this be "10180000.wmac"? > } > > void __init ralink_of_remap(void) > -Gabor