From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQde1-000668-Mr for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:03:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQddw-0001iI-Tt for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:03:57 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:42530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQddw-0001iA-O0 for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:03:52 -0400 Received: by mail-pd0-f182.google.com with SMTP id 3so1408054pdj.13 for ; Fri, 12 Apr 2013 06:03:51 -0700 (PDT) Message-ID: <5168062D.8080104@ozlabs.ru> Date: Fri, 12 Apr 2013 23:03:41 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365730875-22854-1-git-send-email-aik@ozlabs.ru> <5167E747.2020106@suse.de> In-Reply-To: <5167E747.2020106@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] bswap: fix compiler warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini , Richard Henderson , David Gibson On 04/12/2013 08:51 PM, Andreas Färber wrote: > Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: >> The bswap functions use memcpy but the bswap.h header itself does not seem to >> include it in some configuration such as cross compiling for powerpc64 >> on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC18/ppc64), >> the example warning is below. >> >> The patch explicitly includes string.h. >> >> CC ppc64-softmmu/hw/virtio/virtio.o >> In file included from /home/alexey/qemu/include/libfdt_env.h:22:0, >> from /home/alexey/qemu/../lib4qemu/usr/include/libfdt.h:54, >> from /home/alexey/qemu/hw/nvram/spapr_nvram.c:25: >> /home/alexey/qemu/include/qemu/bswap.h: In function 'lduw_p': >> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: implicit declaration of function 'memcpy' [-Wimplicit-function-declaration] >> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: incompatible implicit declaration of built-in function 'memcpy' [enabled by default] >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> include/qemu/bswap.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h >> index d3af35d..d50de0d 100644 >> --- a/include/qemu/bswap.h >> +++ b/include/qemu/bswap.h >> @@ -1,6 +1,8 @@ >> #ifndef BSWAP_H >> #define BSWAP_H >> >> +#include >> + >> #include "config-host.h" >> #include >> #include > > Including string.h is certainly the right thing to do, but why do you > single it out first? I have no idea :) I just tried to do cross compilation and hit this one. And it is not the only problem, I hit another one but this is against gcc or libc, have not discovered it yet. -- Alexey