From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQkVW-0002Ux-Se for qemu-devel@nongnu.org; Fri, 12 Apr 2013 16:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQkVN-0000ul-KT for qemu-devel@nongnu.org; Fri, 12 Apr 2013 16:23:38 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:53855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQkVN-0000uH-FC for qemu-devel@nongnu.org; Fri, 12 Apr 2013 16:23:29 -0400 Received: by mail-pa0-f53.google.com with SMTP id bh4so1633492pad.40 for ; Fri, 12 Apr 2013 13:23:28 -0700 (PDT) Message-ID: <51686D39.3070209@ozlabs.ru> Date: Sat, 13 Apr 2013 06:23:21 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365730875-22854-1-git-send-email-aik@ozlabs.ru> <5167E747.2020106@suse.de> <20130412164715.GL5065@truffula.fritz.box> <51684621.7090204@weilnetz.de> In-Reply-To: <51684621.7090204@weilnetz.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] bswap: fix compiler warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org, David Gibson , Blue Swirl , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Richard Henderson On 04/13/2013 03:36 AM, Stefan Weil wrote: > Am 12.04.2013 18:47, schrieb David Gibson: >> On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote: >>> Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: >>>> The bswap functions use memcpy but the bswap.h header itself does not seem to >>>> include it in some configuration such as cross compiling for powerpc64 >>>> on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC18/ppc64), >>>> the example warning is below. >>>> >>>> The patch explicitly includes string.h. >>>> >>>> CC ppc64-softmmu/hw/virtio/virtio.o >>>> In file included from /home/alexey/qemu/include/libfdt_env.h:22:0, >>>> from /home/alexey/qemu/../lib4qemu/usr/include/libfdt.h:54, >>>> from /home/alexey/qemu/hw/nvram/spapr_nvram.c:25: >>>> /home/alexey/qemu/include/qemu/bswap.h: In function 'lduw_p': >>>> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: implicit declaration of function 'memcpy' [-Wimplicit-function-declaration] >>>> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: incompatible implicit declaration of built-in function 'memcpy' [enabled by default] >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> --- >>>> include/qemu/bswap.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h >>>> index d3af35d..d50de0d 100644 >>>> --- a/include/qemu/bswap.h >>>> +++ b/include/qemu/bswap.h >>>> @@ -1,6 +1,8 @@ >>>> #ifndef BSWAP_H >>>> #define BSWAP_H >>>> >>>> +#include >>>> + >>>> #include "config-host.h" >>>> #include >>>> #include >>> Including string.h is certainly the right thing to do, but why do you >>> single it out first? >> Yeah, it probably shouldn't go above the config header. Otherwise >> it's the right thing. > > If string.h went directly after limits.h, we'd even preserve the > alphabetic order of the system headers :-) Ah. Misunderstood the original question :) Do I need to repost it? -- Alexey