From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Durgin Subject: Re: [PATCH 00/11] rbd: layered read functionality Date: Sun, 14 Apr 2013 10:22:31 -0700 Message-ID: <516AE5D7.4020909@inktank.com> References: <51676E0F.2010504@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f182.google.com ([209.85.192.182]:43226 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117Ab3DNRWi (ORCPT ); Sun, 14 Apr 2013 13:22:38 -0400 Received: by mail-pd0-f182.google.com with SMTP id 3so2123394pdj.27 for ; Sun, 14 Apr 2013 10:22:38 -0700 (PDT) In-Reply-To: <51676E0F.2010504@inktank.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Alex Elder Cc: ceph-devel@vger.kernel.org On 04/11/2013 07:14 PM, Alex Elder wrote: > This series puts in place code that is able to handle > read requests on rbd clone images, forwarding them to > a parent snapshot image if necessary. Missing from this > series is a temporary patch at the end which actually > activates this functionality. That will not go in > until the rest of rbd layering functionality is in place. > > I'm going to restate that. This code implements reads > for layered rbd images, but the functionality will not > be usable quite yet. > > Most of the series is adding flags to image and object > requests, and putting in place some accounting in (parent) > image requests so it can be used to record the completion > of an object request that initiated it. > > -Alex > > [PATCH 01/11] rbd: record overall image request result > [PATCH 02/11] rbd: record aggregate image transfer count > [PATCH 03/11] rbd: record image-relative offset in object requests > [PATCH 04/11] rbd: define image request flags > [PATCH 05/11] rbd: define image request originator flag > [PATCH 06/11] rbd: define image request layered flag > [PATCH 07/11] rbd: encapsulate image object end request handling > [PATCH 08/11] rbd: define an rbd object request flags field > [PATCH 09/11] rbd: add an object request flag for image data objects > [PATCH 10/11] rbd: probe the parent of an image if present > [PATCH 11/11] rbd: implement layered reads These are all pretty straight-forward since the infrastructure is in place. They all look good. Reviewed-by: Josh Durgin