From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UReKA-0001t7-T9 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URe6C-0001DI-TW for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:45:26 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:43736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URe6C-0001Cq-Ky for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:45:12 -0400 Received: by mail-pd0-f170.google.com with SMTP id 10so2368410pdi.1 for ; Mon, 15 Apr 2013 00:45:11 -0700 (PDT) Message-ID: <516BAFFE.9020306@ozlabs.ru> Date: Mon, 15 Apr 2013 17:45:02 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> <516BABA1.8030205@ozlabs.ru> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , David Gibson , qemu-devel@nongnu.org, Stefan Hajnoczi , Gerd Hoffmann On 04/15/2013 05:30 PM, Peter Maydell wrote: > On 15 April 2013 08:26, Alexey Kardashevskiy wrote: >> On 04/15/2013 05:18 PM, Peter Maydell wrote: >>> >>> On 15 April 2013 03:31, Alexey Kardashevskiy wrote: >>>> >>>> The assert.h header file from Fedora18 does not have #ifdef-#endif >>>> brackets around __assertXXXX function so it cannot compile with >>>> the -Wredundant-decls switch on. >>>> >>>> Some Linux distributions (such as Debian Wheezy) still do have those >>>> brackets arounb __assertXXXX functions (#ifndef _ASSERT_H_DECLS) but >>>> the version of assert.h on http://sourceware.org/git/?p=glibc.git does >>>> not >>>> so we should not be using -Wredundant-decls. >>>> >>>> The patch removes it. >>> >>> >>> This commit message seems to be missing any mention of >>> which versions of pixman this change breaks and why >>> it's OK now to break compiling against them... >> >> >> >> The change does not _break_ anything. > > The change breaks the fix that the code was put in to deal with, > ie that pixman-0.16's header files generate warnings, which the > default development qemu will turn into errors with -Werror, which > means we won't compile. > >> The second removed chunk in the patch is the problem as it: >> 1) enables -Wredundant-decls even if it was not enabled before; >> 2) makes -Wredundant-decls an error, not just a warning. > > This is because not all versions of gcc have the push/pop warning > pragma. > >> Default assert.h shipped with Fedora Core 18 (pretty recent and popular >> distribution, I would say) cannot compile with -Wredundant-decls as an error > > This appears to be a bug in Fedora. Rather glibc as it is still in glibc's master branch: http://sourceware.org/git/?p=glibc.git;a=blob;f=assert/assert.h;h=1bb9b2d50f92da3b17cc0b937ecd6141a87dc196;hb=HEAD Or am I looking at wrong git? > I guess the correct workaround for that bug is going to be either: > > * wrap assert.h the same way we wrap pixman.h > * drop -Wredundant-decls :-( The second option seems less ugly. -- Alexey