From: "Bengt Jönsson" <bengt.g.jonsson@stericsson.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
Date: Mon, 15 Apr 2013 11:12:19 +0200 [thread overview]
Message-ID: <516BC473.2070907@stericsson.com> (raw)
In-Reply-To: <1366015011.13029.1.camel@phoenix>
On 04/15/2013 10:36 AM, Axel Lin wrote:
> The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
> selector in get_voltage_sel and set_voltage_sel.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
The patch is correct. Voltage selection is done with 0xc0.
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> ---
> Hi Bengt,
> I don't have the datasheet. Can you confirm if this fix is correct?
>
> BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few
> days ago? I ask this because now I have more patches that may depend on previous
> patches.
>
> Thanks,
> Axel
>
> drivers/regulator/ab8500.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index b81ff04..0a62ef9 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info
> .voltage_bank = 0x03,
> .voltage_reg = 0x83,
> .voltage_mask = 0xc0,
> + .voltage_shift = 6,
> },
>
> /*
next prev parent reply other threads:[~2013-04-15 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 8:36 [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC Axel Lin
2013-04-15 9:12 ` Bengt Jönsson [this message]
2013-04-15 15:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BC473.2070907@stericsson.com \
--to=bengt.g.jonsson@stericsson.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.