Re: [Qemu-trivial] [PATCH v2] bswap: fix compiler warning

["Andreas Färber" <afaerber@suse.de>]

Am 15.04.2013 03:47, schrieb Alexey Kardashevskiy:
> The bswap functions use memcpy but the bswap.h header itself does not seem to
> include it in some configuration such as cross compiling for powerpc64
> on x86_64 machine.
> 
> The patch explicitly includes string.h.
> 
> v2:
> * #include statement moved to the right place
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  include/qemu/bswap.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index d3af35d..14a5f65 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -4,6 +4,7 @@
>  #include "config-host.h"
>  #include <inttypes.h>
>  #include <limits.h>
> +#include <string.h>
>  #include "fpu/softfloat.h"
>  
>  #ifdef CONFIG_MACHINE_BSWAP_H

Thanks,

Reviewed-by: Andreas Färber <afaerber@suse.de>

Normally the change log does not go into the commit message but I'm sure
Stefan can fix that. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg