From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URiOJ-00070i-Mh for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:20:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URiOD-0003GZ-Om for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:20:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35826 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URiOD-0003Fn-J2 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:20:05 -0400 Message-ID: <516BF073.9060609@suse.de> Date: Mon, 15 Apr 2013 14:20:03 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366027532-1120-1-git-send-email-pbonzini@redhat.com> <1366027532-1120-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1366027532-1120-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: gnatapov@redhat.com, qemu-devel@nongnu.org, agraf@suse.de Am 15.04.2013 14:05, schrieb Paolo Bonzini: > Now that we have a CPU object with a reset method, it is better to > keep the KVM reset close to the CPU reset. Using qemu_register_reset > as we do now keeps them far apart. >=20 > Signed-off-by: Paolo Bonzini > --- > v2->v3: add stub kvm_arch_reset_vcpu for s390 >=20 > include/sysemu/kvm.h | 2 -- > kvm-all.c | 11 ----------- > target-arm/kvm.c | 4 ---- > target-i386/cpu.c | 5 +++++ > target-i386/kvm_i386.h | 1 + > target-ppc/kvm.c | 4 ---- > target-s390x/cpu.c | 4 ++++ > target-s390x/cpu.h | 5 +++++ > 8 files changed, 15 insertions(+), 21 deletions(-) Fine with me. Have you tested whether i386 needs a similar stub on non-x86? If so then Reviewed-by: Andreas F=E4rber For anyone else wondering, arm and ppc are no longer calling the kvm_arch_ function, so it can get removed there, while i386 and s390x call it from X86CPU/S390CPU reset handler now. Would be more clear if the commit message was more verbose ;) and would be nice to clean this up as follow-up by renaming to kvm_x86_... and kvm_s390_... or so respectively. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg