From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx Date: Mon, 15 Apr 2013 15:39:15 +0300 Message-ID: <516BF4F3.5060904@ti.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1366029306-1824-1-git-send-email-rogerq@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: b-cousson@ti.com, tony@atomide.com Cc: devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros List-Id: linux-omap@vger.kernel.org T24gMDQvMTUvMjAxMyAwMzozNSBQTSwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPiBQcm92aWRlIFJF U0VUIGFuZCBQb3dlciByZWd1bGF0b3JzIGZvciB0aGUgVVNCIFBIWSwKPiB0aGUgVVNCIEhvc3Qg cG9ydCBtb2RlIGFuZCB0aGUgUEhZIGRldmljZS4KPiAKPiBBbHNvIHByb3ZpZGUgcGluIG11bHRp cGxleGVyIGluZm9ybWF0aW9uIGZvciBVU0IgaG9zdAo+IHBpbnMuCj4gCj4gVGhpcyB3aWxsIG5v dCB3b3JrIGZvciBSZXYgQ3ggYm9hcmRzIGJlY2F1c2Ugb2YgcmV2ZXJzZWQgbG9naWMKPiBmb3Ig VVNCX1BPV0VSX0VuYWJsZS4KPiAKPiBDQzogQmVub8OudCBDb3Vzc29uIDxiLWNvdXNzb25AdGku Y29tPgo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFF1YWRyb3MgPHJvZ2VycUB0aS5jb20+Cj4gLS0t Cj4gIGFyY2gvYXJtL2Jvb3QvZHRzL29tYXAzLWJlYWdsZS14bS5kdHMgfCAgIDYyICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGVzIGNoYW5nZWQsIDYyIGluc2VydGlv bnMoKyksIDAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRz L29tYXAzLWJlYWdsZS14bS5kdHMgYi9hcmNoL2FybS9ib290L2R0cy9vbWFwMy1iZWFnbGUteG0u ZHRzCj4gaW5kZXggNWEzMTk2NC4uZDM5NGM1MSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290 L2R0cy9vbWFwMy1iZWFnbGUteG0uZHRzCj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDMt YmVhZ2xlLXhtLmR0cwo+IEBAIC01Nyw2ICs1Nyw2MCBAQAo+ICAJCXRpLG1jYnNwID0gPCZtY2Jz cDI+Owo+ICAJCXRpLGNvZGVjID0gPCZ0d2xfYXVkaW8+Owo+ICAJfTsKPiArCj4gKwkvKiBIUyBV U0IgUG9ydCAyIFJFU0VUICovCj4gKwloc3VzYjJfcmVzZXQ6IGhzdXNiMl9yZXNldF9yZWcgewo+ ICsJCWNvbXBhdGlibGUgPSAicmVndWxhdG9yLWZpeGVkIjsKPiArCQlyZWd1bGF0b3ItbmFtZSA9 ICJoc3VzYjJfcmVzZXQiOwo+ICsJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+ Owo+ICsJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ICsJCWdwaW8gPSA8 JmdwaW81IDE5IDA+OwkvKiBncGlvXzE0NyAqLwo+ICsJCXN0YXJ0dXAtZGVsYXktdXMgPSA8NzAw MDA+Owo+ICsJCWVuYWJsZS1hY3RpdmUtaGlnaDsKPiArCX07Cj4gKwo+ICsJLyogSFMgVVNCIFBv cnQgMiBQb3dlciAqLwo+ICsJaHN1c2IyX3Bvd2VyOiBoc3VzYjJfcG93ZXJfcmVnIHsKPiArCQlj b21wYXRpYmxlID0gInJlZ3VsYXRvci1maXhlZCI7Cj4gKwkJcmVndWxhdG9yLW5hbWUgPSAiaHN1 c2IyX3ZidXMiOwo+ICsJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ICsJ CXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ICsJCWdwaW8gPSA8JnR3bF9n cGlvIDE4IDA+OwkvKiBHUElPIExFREEgKi8KPiArCQlzdGFydHVwLWRlbGF5LXVzID0gPDcwMDAw PjsKPiArCQllbmFibGUtYWN0aXZlLWhpZ2g7CS8qIEZJWE1FOiBhY3RpdmUtbG93IGZvciBSZXYu IEMgKi8KCkJlbm9pdCAmIFRvbnksCgpBbnkgaWRlYXMgaG93IHRvIHRhY2tsZSB0aGUgcmV2ZXJz ZWQgbG9naWMgZm9yIFJldi4gQyBib2FyZHM/Cgo+ICsJfTsKPiArCj4gKwkvKiBIUyBVU0IgSG9z dCBQSFkgb24gUE9SVCAyICovCj4gKwloc3VzYjJfcGh5OiBoc3VzYjJfcGh5IHsKPiArCQljb21w YXRpYmxlID0gInVzYi1ub3AteGNlaXYiOwo+ICsJCXJlc2V0LXN1cHBseSA9IDwmaHN1c2IyX3Jl c2V0PjsKPiArCQl2Y2Mtc3VwcGx5ID0gPCZoc3VzYjJfcG93ZXI+Owo+ICsJfTsKPiArCj4gK307 CgpjaGVlcnMsCi1yb2dlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Mon, 15 Apr 2013 15:39:15 +0300 Subject: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx In-Reply-To: <1366029306-1824-1-git-send-email-rogerq@ti.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> Message-ID: <516BF4F3.5060904@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/15/2013 03:35 PM, Roger Quadros wrote: > Provide RESET and Power regulators for the USB PHY, > the USB Host port mode and the PHY device. > > Also provide pin multiplexer information for USB host > pins. > > This will not work for Rev Cx boards because of reversed logic > for USB_POWER_Enable. > > CC: Beno?t Cousson > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/omap3-beagle-xm.dts | 62 +++++++++++++++++++++++++++++++++ > 1 files changed, 62 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > index 5a31964..d394c51 100644 > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > @@ -57,6 +57,60 @@ > ti,mcbsp = <&mcbsp2>; > ti,codec = <&twl_audio>; > }; > + > + /* HS USB Port 2 RESET */ > + hsusb2_reset: hsusb2_reset_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb2_reset"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio5 19 0>; /* gpio_147 */ > + startup-delay-us = <70000>; > + enable-active-high; > + }; > + > + /* HS USB Port 2 Power */ > + hsusb2_power: hsusb2_power_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb2_vbus"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ > + startup-delay-us = <70000>; > + enable-active-high; /* FIXME: active-low for Rev. C */ Benoit & Tony, Any ideas how to tackle the reversed logic for Rev. C boards? > + }; > + > + /* HS USB Host PHY on PORT 2 */ > + hsusb2_phy: hsusb2_phy { > + compatible = "usb-nop-xceiv"; > + reset-supply = <&hsusb2_reset>; > + vcc-supply = <&hsusb2_power>; > + }; > + > +}; cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933490Ab3DOMj2 (ORCPT ); Mon, 15 Apr 2013 08:39:28 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55851 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933304Ab3DOMjY (ORCPT ); Mon, 15 Apr 2013 08:39:24 -0400 Message-ID: <516BF4F3.5060904@ti.com> Date: Mon, 15 Apr 2013 15:39:15 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: , CC: Roger Quadros , , , , Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx References: <1366029306-1824-1-git-send-email-rogerq@ti.com> In-Reply-To: <1366029306-1824-1-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2013 03:35 PM, Roger Quadros wrote: > Provide RESET and Power regulators for the USB PHY, > the USB Host port mode and the PHY device. > > Also provide pin multiplexer information for USB host > pins. > > This will not work for Rev Cx boards because of reversed logic > for USB_POWER_Enable. > > CC: Benoît Cousson > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/omap3-beagle-xm.dts | 62 +++++++++++++++++++++++++++++++++ > 1 files changed, 62 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > index 5a31964..d394c51 100644 > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > @@ -57,6 +57,60 @@ > ti,mcbsp = <&mcbsp2>; > ti,codec = <&twl_audio>; > }; > + > + /* HS USB Port 2 RESET */ > + hsusb2_reset: hsusb2_reset_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb2_reset"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio5 19 0>; /* gpio_147 */ > + startup-delay-us = <70000>; > + enable-active-high; > + }; > + > + /* HS USB Port 2 Power */ > + hsusb2_power: hsusb2_power_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb2_vbus"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ > + startup-delay-us = <70000>; > + enable-active-high; /* FIXME: active-low for Rev. C */ Benoit & Tony, Any ideas how to tackle the reversed logic for Rev. C boards? > + }; > + > + /* HS USB Host PHY on PORT 2 */ > + hsusb2_phy: hsusb2_phy { > + compatible = "usb-nop-xceiv"; > + reset-supply = <&hsusb2_reset>; > + vcc-supply = <&hsusb2_power>; > + }; > + > +}; cheers, -roger