From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: gnatapov@redhat.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method
Date: Mon, 15 Apr 2013 14:55:13 +0200 [thread overview]
Message-ID: <516BF8B1.4010605@redhat.com> (raw)
In-Reply-To: <516BF073.9060609@suse.de>
Il 15/04/2013 14:20, Andreas Färber ha scritto:
> Fine with me.
>
> Have you tested whether i386 needs a similar stub on non-x86? If so then
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
It doesn't need it, because the prototype is declared always in kvm_i386.h.
I didn't test non-x86, but I tested an alternative patches that places
s390's kvm_arch_reset_vcpu prototype outside "#ifdef CONFIG_KVM". That
also compiled fine on non-s390, and it's what will happen when compiling
on non-x86.
I figured that the dummy inline definition was closer in style to the
existing s390 code, so that's what I chose for submission.
Paolo
next prev parent reply other threads:[~2013-04-15 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 12:05 [Qemu-devel] [PATCH uq/master v3 0/2] correctly reset the CPU on INIT interrupts Paolo Bonzini
2013-04-15 12:05 ` [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method Paolo Bonzini
2013-04-15 12:20 ` Andreas Färber
2013-04-15 12:55 ` Paolo Bonzini [this message]
2013-04-18 5:37 ` Gleb Natapov
2013-04-18 7:37 ` Paolo Bonzini
2013-04-15 12:05 ` [Qemu-devel] [PATCH uq/master v3 2/2] kvm: forward INIT signals coming from the chipset Paolo Bonzini
2013-04-18 7:54 ` [Qemu-devel] [PATCH uq/master v3 0/2] correctly reset the CPU on INIT interrupts Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BF8B1.4010605@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=gnatapov@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.