From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URj4U-0003Ax-IP for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:03:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URj4Q-00031z-EX for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:03:46 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:45251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URj4Q-00031p-9Y for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:03:42 -0400 Received: by mail-pa0-f47.google.com with SMTP id bj3so2531079pad.6 for ; Mon, 15 Apr 2013 06:03:41 -0700 (PDT) Message-ID: <516BFAA7.1000208@ozlabs.ru> Date: Mon, 15 Apr 2013 23:03:35 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> <8761zofezy.fsf@blackfin.pond.sub.org> <516BA87A.2020107@ozlabs.ru> <874nf8cidj.fsf@blackfin.pond.sub.org> <516BCD71.9070905@ozlabs.ru> <516BDBFB.5070602@ozlabs.ru> <87vc7ovtnm.fsf@blackfin.pond.sub.org> In-Reply-To: <87vc7ovtnm.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , qemu-devel@nongnu.org, Blue Swirl , Gerd Hoffmann , Stefan Hajnoczi , David Gibson On 04/15/2013 10:57 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 04/15/2013 08:01 PM, Peter Maydell wrote: >>> On 15 April 2013 10:50, Alexey Kardashevskiy wrote: >>>> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: >>>> error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls] >>>> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: >>>> note: previous declaration of '__assert_fail' was here >>>> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:72:13: >>>> error: redundant redeclaration of '__assert_perror_fail' >>>> [-Werror=redundant-decls] >>> >>> This copy of assert.h seems to be broken. The declarations >>> should be guarded (by _ASSERT_H_DECLS in my system's copy). >> >> Debian? It uses eglibc which is fork (or clone?) of glibc. >> >>> If it's widespread we might have to work around this. >> >> It is in fedora 18 and glibc's git master branch. Why "if"? > > It's in Fedora 17, too, but I *don't* get a warning. Suspecting your > compiler. --version? powerpc64-linux-gcc 4.6.3, 4.7.2, 4.8.0, all the same. I'll try to track it down tomorrow why it all works when host and target are the same (pretty sure this is the cse) but I just do not get it... It is just me who sees obvious error in assert.h which is caused by -Wno-redundant-decls? Even if you do not hit this now, you will get there eventually. -- Alexey