Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On 04/15/2013 06:10 AM, Kevin Wolf wrote:
> Am 11.04.2013 um 11:20 hat Markus Armbruster geschrieben:
>> [Cc: Wenchao Xia because of overlap with his work]
>>
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> On 04/10/2013 08:05 AM, Pavel Hrdina wrote:
>>>> Here is another proposal how to handle vm snapshots:
>>>>
>>>> QMP vm-snapshot-save:
>>>>     - { 'command': 'vm-snapshot-save',
>>>>         'data': { 'name': 'str' },
>>>>         'returns': 'SnapshotInfo' }
>>>>     - vm-snapshot-save returns an error if there is an existing
>>>>       snapshot with the same name
>>>>     - you cannot provide an id for a new snapshot
>>>>     - on success all information about created snapshot will be returned
> 
> Would it make sense to (optionally) let the caller specify in which
> image the VM state will be stored, or whether it should be stored at
> all?

Yes, please.  Libvirt already has the XML to express this, but can't
wire it up unless qemu exposes that level of control.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]