From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjIh-0007gf-RE for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:18:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URjIb-0000us-OV for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:18:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39070 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjIb-0000uY-GL for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:18:21 -0400 Message-ID: <516BFE1B.2030204@suse.de> Date: Mon, 15 Apr 2013 15:18:19 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365710844-30453-1-git-send-email-ehabkost@redhat.com> <1365710844-30453-2-git-send-email-ehabkost@redhat.com> <20130415102743.3d3ed016@nial.usersys.redhat.com> In-Reply-To: <20130415102743.3d3ed016@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding style fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Eduardo Habkost , qemu-devel@nongnu.org Am 15.04.2013 10:27, schrieb Igor Mammedov: > On Thu, 11 Apr 2013 17:07:23 -0300 > Eduardo Habkost wrote: >=20 >> * Add braces to 'if' statements; >> * Remove last TAB character from the source. >> >> Signed-off-by: Eduardo Habkost >> --- >> target-i386/cpu.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index f1ccc72..c2e02fe 100644 >> --- a/target-i386/cpu.c >> +++ b/target-i386/cpu.c >> @@ -1870,12 +1870,13 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t >> index, uint32_t count, if (env->cpuid_ext2_features & CPUID_EXT2_LM) { >> /* 64 bit processor */ >> /* XXX: The physical address space is limited to 42 bits in exec.c. *= / >> - *eax =3D 0x00003028; /* 48 bits virtual, 40 bits physical >> */ >> + *eax =3D 0x00003028; /* 48 bits virtual, 40 bits physica= l */ > ^^ 2 spaces when in other places only = one > =20 >> } else { >> - if (env->cpuid_features & CPUID_PSE36) >> + if (env->cpuid_features & CPUID_PSE36) { >> *eax =3D 0x00000024; /* 36 bits physical */ >> - else >> + } else { >> *eax =3D 0x00000020; /* 32 bits physical */ >> + } >> } >> *ebx =3D 0; >> *ecx =3D 0; >=20 > with fix above Reviewed-By: Igor Mammedov Thanks, applied to qom-cpu (with suggested change to spare resends): https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg