From: Laszlo Ersek <lersek@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups
Date: Mon, 15 Apr 2013 15:31:25 +0200 [thread overview]
Message-ID: <516C012D.20508@redhat.com> (raw)
In-Reply-To: <516BFF70.8050907@redhat.com>
On 04/15/13 15:24, Laszlo Ersek wrote:
> Second, 2/3 breaks the binary format exported under the
> FW_CFG_ACPI_TABLES key. The format is as follows:
>
> * number of tables in entire fw_cfg blob : uint16_t
> for each table:
> * ACPI payload size belonging to this table : uint16_t
> * standard ACPI header
> * ACPI table contents
>
> whereas 2/3 changes the format to:
>
> * zero-filled uint16_t (i)
> for each table:
> * uint16_t storing value 1 in LE order (ii)
> * number of bytes in blob segment belonging to this table : uint16_t
Sorry, this was mis-editing the email on my part: the _length field is
computed alright, it's only the (i)<->(ii) thing that goes wrong.
> * standard ACPI header
> * ACPI table contents
>
> (ii) shouldn't exist in per-table storage, the increments should target
> (i) actually.
Laszlo
next prev parent reply other threads:[~2013-04-15 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 9:37 [Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups Michael S. Tsirkin
2013-04-15 9:37 ` [Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to acpi.h Michael S. Tsirkin
2013-04-15 10:42 ` Paolo Bonzini
2013-04-15 11:00 ` Laszlo Ersek
2013-04-15 11:00 ` Paolo Bonzini
2013-04-15 9:37 ` [Qemu-devel] [PATCH 2/3] acpi: add acpi_table_add_hdr Michael S. Tsirkin
2013-04-15 9:37 ` [Qemu-devel] [PATCH 3/3] acpi.h: make it self contained Michael S. Tsirkin
2013-04-15 11:25 ` [Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups Michael S. Tsirkin
2013-04-15 13:24 ` Laszlo Ersek
2013-04-15 13:31 ` Laszlo Ersek [this message]
2013-04-15 14:05 ` Michael S. Tsirkin
2013-04-15 21:10 ` Anthony Liguori
2013-04-15 21:26 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C012D.20508@redhat.com \
--to=lersek@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.