From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjYA-0001Le-Nz for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URjY9-0007no-Eu for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:34:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39783 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjY9-0007nV-8p for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:34:25 -0400 Message-ID: <516C01DE.6070309@suse.de> Date: Mon, 15 Apr 2013 15:34:22 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com> <1365944470-13837-9-git-send-email-fred.konrad@greensocs.com> In-Reply-To: <1365944470-13837-9-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com Am 14.04.2013 15:01, schrieb fred.konrad@greensocs.com: > From: KONRAD Frederic >=20 > As the virtio-rng-pci and virtio-rng-s390 are switched to the new API, and virtio-rng-ccw ;) > we can use QOM casts. >=20 > Signed-off-by: KONRAD Frederic > --- > hw/virtio/virtio-rng.c | 31 +++++++++++++++++-------------- > include/hw/virtio/virtio-rng.h | 2 +- > 2 files changed, 18 insertions(+), 15 deletions(-) Thanks, Reviewed-by: Andreas F=E4rber I was surprised to see FOO(opaque) since we usually try to avoid it for performance reasons, but it's not forbidden either. Also, leaving the variable name as "s" would've spared a few lines but so what. :) Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg