From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkTx-0005vj-O5 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URkTw-0006RX-Jb for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:34:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkTw-0006RQ-Ch for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:34:08 -0400 Message-ID: <516C0FD0.50409@redhat.com> Date: Mon, 15 Apr 2013 16:33:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366035288-15840-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1366035288-15840-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] nbd: use TCP_NODELAY List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Nick Thomas Il 15/04/2013 16:14, Stefan Hajnoczi ha scritto: > The nbd block driver should use TCP_NODELAY. Nick Thomas > measured a 40 millisecond latency added by the Naggle algorithm. > > This series turns on TCP_NODELAY. This requires that we use TCP_CORK to > efficiently send NBD requests that contain a payload after the header. > > Finally, fix a bug where we forget to unlock a mutex when sending fails. > > Stefan Hajnoczi (3): > nbd: unlock mutex in nbd_co_send_request() error path > nbd: use TCP_CORK in nbd_co_send_request() > nbd: set TCP_NODELAY > > block/nbd.c | 25 +++++++++++++++++++------ > 1 file changed, 19 insertions(+), 6 deletions(-) > Thanks, applied all to nbd-next. I also marked patch 1 for stable branches. Paolo