From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URlGq-0003Tk-7X for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:24:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URlGo-0001Cv-VT for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:24:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48156 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URlGo-0001Cj-Ps for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:24:38 -0400 Message-ID: <516C1BB4.5050607@suse.de> Date: Mon, 15 Apr 2013 17:24:36 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-9-git-send-email-imammedo@redhat.com> In-Reply-To: <1365691918-30594-9-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, lig.fnst@cn.fujitsu.com, rth@twiddle.net Am 11.04.2013 16:51, schrieb Igor Mammedov: > get_arch_id() adds possibility for generic code to get guest visible > CPI id without accessing CPUArchState. If target doesn't override it, > it will return cpu_index. >=20 > Override it on target-i386 to return APIC ID. >=20 > Signed-off-by: Igor Mammedov > --- > * it will be used later by new cpu_exists() generic function and > acpi_piix. > * s/cpu_firmware_id/cpu_arch_id/ > --- > include/qom/cpu.h | 2 ++ > qom/cpu.c | 6 ++++++ > target-i386/cpu.c | 10 ++++++++++ > 3 files changed, 18 insertions(+) I'm still unclear about this ID topic, but please don't add QOM methods with arch_ in the name. The arch is expressed through subclasses. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg