From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URleG-0004Ah-Kx for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:48:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URleF-0002OX-5c for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:48:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50514 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URleE-0002O6-UK for qemu-devel@nongnu.org; Mon, 15 Apr 2013 11:48:51 -0400 Message-ID: <516C2161.8040005@suse.de> Date: Mon, 15 Apr 2013 17:48:49 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-18-git-send-email-imammedo@redhat.com> In-Reply-To: <1365691918-30594-18-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, lig.fnst@cn.fujitsu.com, rth@twiddle.net Am 11.04.2013 16:51, schrieb Igor Mammedov: > Currently device_set_realized() sets parent only after device was reali= zed, > But qdev_device_add() sets it before device is realized. > Make behavior consistent and alter device_set_realized() to behave like > qdev_device_add(). >=20 > It will allow to set link<> properties in realize() method in classes > inherited from DEVICE. >=20 > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini > --- > * Usage examples > - conversion to CPU back-link property in APIC > - pre-allocate link at board level, and populate them > at realize time when CPUs are created. > --- > hw/core/qdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg