From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URm36-0005u8-Ms for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:14:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URm32-0004Og-7Z for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:14:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URm31-0004Oa-Ve for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:14:28 -0400 Message-ID: <516C275B.8080502@redhat.com> Date: Mon, 15 Apr 2013 18:14:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366031973-7718-1-git-send-email-pbonzini@redhat.com> <1366031973-7718-8-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Il 15/04/2013 18:09, Peter Maydell ha scritto: >> > +if test "$targetos" = Linux && test "$cpu" = i386 -o "$cpu" = x86_64; then > test -o is deprecated by POSIX; better to use > if test ... && ( test ... || test ... ); then > > in new code. True, on the other hand "(.*test" has no match at all in configure; and since we know that $cpu does not begin with a dash, it is portable in practice. I would agree with you, but it looks like convention trumps the suggested practice. Paolo