From: Daiane Angolini <daiane.angolini@freescale.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: meta-freescale Mailing List <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs
Date: Mon, 15 Apr 2013 13:40:41 -0300 [thread overview]
Message-ID: <516C2D89.1090703@freescale.com> (raw)
In-Reply-To: <CAP9ODKpAd5cUYv8zz5JkF-YBpR2L4=ow2yO9WKASq1Gfbq3xtw@mail.gmail.com>
On 04/15/2013 11:14 AM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>
>>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>>> don't have the firmware package for them so comment them out so it
>>> doesn't break the build.
>>
>> Why to keep this code? I would prefer to remove the lines instead of comment
>> them.
>
> I can remove it but I kept it as it is the name of the generated files
> and makes it easier to add it back (also has the FIXME). So if someone
> grep the code looking for firmware for it, it'll find it commented and
> with a FIXME on top of it.
>
> What do you think?
I prefer to remove the code. But, it's not that hard preference.
Daiane
next prev parent reply other threads:[~2013-04-15 16:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 11:51 [meta-fsl-arm PATCH v3 0/13] Fixes current found issues for 1.4 release Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 01/13] u-boot-fslc: Update to patches-2013.04's 20130410 snapshot Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 02/13] imx6dlsabresd: Use U-Boot 2009.08 from Freescale Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 03/13] gst-fsl-plugin (3.0.6): Fix the tarball's checksum Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 04/13] gst-fsl-plugin (3.0.6): Add 'virtual/kernel' dependency Otavio Salvador
2013-04-15 14:00 ` Daiane Angolini
2013-04-15 14:12 ` Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs Otavio Salvador
2013-04-15 14:02 ` Daiane Angolini
2013-04-15 14:14 ` Otavio Salvador
2013-04-15 16:40 ` Daiane Angolini [this message]
2013-04-15 17:10 ` Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 06/13] imx-base.inc: Avoid including imx-audio for every SoC family Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 07/13] imx-base.inc: Override GStreamer plugins for i.MX3 Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 08/13] imx-base.inc: Fix i.MX6SL entry point hex format Otavio Salvador
2013-04-15 15:24 ` Daiane Angolini
2013-04-15 16:12 ` Otavio Salvador
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS Otavio Salvador
2013-04-15 15:26 ` Daiane Angolini
2013-04-15 16:13 ` Otavio Salvador
2013-04-15 16:42 ` Daiane Angolini
2013-04-15 11:51 ` [meta-fsl-arm PATCH v3 10/13] Fix use of SOC_FAMILY as the most right value is preferred Otavio Salvador
2013-04-15 11:52 ` [meta-fsl-arm PATCH v3 11/13] xf86-dri-vivante: Ensure install fails if .la cannot be removed Otavio Salvador
2013-04-15 15:29 ` Daiane Angolini
2013-04-15 16:14 ` Otavio Salvador
2013-04-15 11:52 ` [meta-fsl-arm PATCH v3 12/13] xf86-dri-vivante: Fix DRI module name Otavio Salvador
2013-04-15 15:30 ` Daiane Angolini
2013-04-15 16:15 ` Otavio Salvador
2013-04-15 16:41 ` Daiane Angolini
2013-04-15 11:52 ` [meta-fsl-arm PATCH v3 13/13] xf86-video-imxfb-vivante: Enable software rendering support Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C2D89.1090703@freescale.com \
--to=daiane.angolini@freescale.com \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.