From: Alex Elder <elder@inktank.com>
To: Laurent Barbe <laurent@ksperis.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] rbd: revalidate_disk upon rbd resize
Date: Mon, 15 Apr 2013 12:24:37 -0500 [thread overview]
Message-ID: <516C37D5.1090804@inktank.com> (raw)
In-Reply-To: <1365774766-29899-1-git-send-email-laurent@ksperis.com>
On 04/12/2013 08:52 AM, Laurent Barbe wrote:
> If rbd disk is open and rbd resize is done, new size is not visible by
> filesystem.
> Like is done in virtio-blk and dm driver, revalidate_disk() permits to
> update the bd_inode size.
>
> Signed-off-by: Laurent Barbe <laurent@ksperis.com>
This one looks good (too). And this time I've tested
it just to be sure I get no lockdep warnings. Unless
I see any strangeness in my sanity testing (which I
don't expect) I'll commit this to the testing branch
later today. Thanks a lot.
Reviewed-by: Alex Elder <elder@inktank.com>
> ---
> drivers/block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4daa400..5f88de9 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -1883,6 +1883,7 @@ static int rbd_dev_refresh(struct rbd_device *rbd_dev, u64 *hver)
> else
> ret = rbd_dev_v2_refresh(rbd_dev, hver);
> mutex_unlock(&ctl_mutex);
> + revalidate_disk(rbd_dev->disk);
>
> return ret;
> }
>
next prev parent reply other threads:[~2013-04-15 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 13:52 [PATCH] rbd: revalidate_disk upon rbd resize Laurent Barbe
2013-04-12 13:59 ` Laurent Barbe
2013-04-15 17:24 ` Alex Elder [this message]
2013-04-22 17:10 ` Alex Elder
2013-04-22 17:14 ` Sage Weil
2013-04-22 17:35 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2013-04-10 16:06 Laurent Barbe
2013-04-10 19:30 ` Alex Elder
2013-04-11 2:53 ` Alex Elder
[not found] ` <CADksbcpbhp8-Db2bqQc_fFwmT-iObYdjK+rXJF5DiZ9wu1sSQA@mail.gmail.com>
2013-04-11 13:27 ` Alex Elder
2013-04-11 13:59 ` Laurent Barbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C37D5.1090804@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=laurent@ksperis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.