From: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable
Date: Mon, 15 Apr 2013 21:44:04 -0500 [thread overview]
Message-ID: <516CBAF4.5010701@linux.vnet.ibm.com> (raw)
In-Reply-To: <1365992066-24348-2-git-send-email-lig.fnst@cn.fujitsu.com>
On 04/14/2013 09:14 PM, liguang wrote:
> #ifdef DEBUG_DEBUGCON
> - printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
> + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02]\n", addr, val);
I like the reformatting, but it looks like you accidentally clobbered the
'x' when you added the ']'. This is the cause of the compiler warnings in
patch #3.
Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
jlarrew@linux.vnet.ibm.com
next prev parent reply other threads:[~2013-04-16 2:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 2:14 [Qemu-devel] [PATCH v2 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug liguang
2013-04-15 2:14 ` [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable liguang
2013-04-16 2:44 ` Jesse Larrew [this message]
2013-04-16 3:39 ` li guang
2013-04-15 2:14 ` [Qemu-devel] [PATCH v2 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
2013-04-16 2:51 ` Jesse Larrew
2013-04-16 3:00 ` li guang
2013-04-16 2:37 ` [Qemu-devel] [PATCH v2 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug Jesse Larrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516CBAF4.5010701@linux.vnet.ibm.com \
--to=jlarrew@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.