All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] ARM: OMAP: Correct save_boot_params and replace with 'C' function
Date: Tue, 16 Apr 2013 09:34:00 +0530	[thread overview]
Message-ID: <516CCDB0.6080407@ti.com> (raw)
In-Reply-To: <998DF6E6-9F7A-4AD9-B046-76590EA186C0@prograde.net>

On Monday 15 April 2013 09:52 PM, Michael Cashwell wrote:
> Hi Sricharan,
> 
> I very much like how you've structured this. A vast improvement!
> 
> I haven't yet tried to apply the whole series but have one quick comment. In the new function:
> 
> static void save_omap_boot_params(void)
> {
> ...
>   if (!(omap_hw_init_context() ==
>        OMAP_INIT_CONTEXT_UBOOT_AFTER_SPL)) {
>       ...
>   } else {
>       ...
>   }
> 
> wouldn't it be clearer to drop the boolean negation "!" and exchange the if/else bodies?
> 
 hmm, will do and add a comment as well.

Regards,
 Sricharan

  reply	other threads:[~2013-04-16  4:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 15:08 [U-Boot] [PATCH 0/5] ARM: OMAP: Cleanup save_boot_params function Sricharan R
2013-04-15 15:08 ` [U-Boot] [PATCH 1/5] ARM: OMAP: Make omap_boot_parameters common across socs Sricharan R
2013-04-15 15:08 ` [U-Boot] [PATCH 2/5] ARM: OMAP4/5: Make OMAPx_SRAM_SCRATCH_ defines common Sricharan R
2013-04-15 15:08 ` [U-Boot] [PATCH 3/5] ARM: OMAP: Correct save_boot_params and replace with 'C' function Sricharan R
2013-04-15 15:28   ` Tom Rini
2013-04-15 15:33     ` Sricharan R
2013-04-15 16:22   ` Michael Cashwell
2013-04-16  4:04     ` Sricharan R [this message]
2013-04-15 15:08 ` [U-Boot] [PATCH 4/5] ARM: OMAP: Cleanup boot parameters usage Sricharan R
2013-04-15 15:35   ` Tom Rini
2013-04-15 15:39     ` Sricharan R
2013-04-15 15:43       ` Tom Rini
2013-04-16  4:00         ` Sricharan R
2013-04-15 15:08 ` [U-Boot] [PATCH 5/5] ARM: OMAP: Add arch_cpu_init function Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516CCDB0.6080407@ti.com \
    --to=r.sricharan@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.