From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Michael Witten <mfwitten@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PROBLEM] perf requires python-devel to compile
Date: Mon, 15 Apr 2013 21:26:40 -0700 [thread overview]
Message-ID: <516CD300.6070201@gmail.com> (raw)
In-Reply-To: <87mwszb4s6.fsf@sejong.aot.lge.com>
On 4/15/13 7:14 PM, Namhyung Kim wrote:
>> Makefile:755: The path '/usr/bin/python-config' is not executable.
>> Makefile:755: *** Please set 'PYTHON_CONFIG' appropriately. Stop.
>>
>> The problem is that I didn't have python-devel package installed and
>> get-executable-or-default decides to error out instead of letting the
>> Makefile disable Python support.
>
> Right. I think the get-executable-or-default should not error out in
> this case but just emit a warning and keep building.
>
> Does following patch fix your problem?
>
> -----------8<-------------8<-------------
> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 8ef3bd30a549..3b8036f8aca4 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -177,7 +177,7 @@ $(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2),$(1)))
> endef
> _ge_attempt = $(if $(get-executable),$(get-executable),$(_gea_warn)$(call _gea_err,$(2)))
> _gea_warn = $(warning The path '$(1)' is not executable.)
> -_gea_err = $(if $(1),$(error Please set '$(1)' appropriately))
> +_gea_err = $(if $(1),$(warning Please set '$(1)' appropriately))
In this case you don't want a warning, you just want python support
disabled and move on. I've been getting around this in a minimal install
of F18 in a VM using PYTHON_CONFIG=/bin/false; haven't had time to
search for the proper solution.
David
next prev parent reply other threads:[~2013-04-16 4:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 10:58 [PROBLEM] perf requires python-devel to compile Pekka Enberg
2013-04-16 2:14 ` Namhyung Kim
2013-04-16 4:26 ` David Ahern [this message]
2013-04-16 17:08 ` Michael Witten
2013-04-16 20:32 ` David Ahern
2013-04-16 20:41 ` Michael Witten
2013-04-17 2:23 ` [PATCH] perf tools: Revert regression in configuration of Python support Michael Witten
2013-04-16 17:16 ` [PROBLEM] perf requires python-devel to compile Pekka Enberg
2013-07-12 8:52 ` [tip:perf/urgent] perf tools: Revert regression in configuration of Python support tip-bot for Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516CD300.6070201@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mfwitten@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.