From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1URxkk-0007jF-2F
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 00:44:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1URxkg-00067P-St
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 00:44:21 -0400
Received: from e8.ny.us.ibm.com ([32.97.182.138]:33545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1URxkg-00066r-Oi
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 00:44:18 -0400
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Tue, 16 Apr 2013 00:44:16 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 2436B6E803C
	for <qemu-devel@nongnu.org>; Tue, 16 Apr 2013 00:44:11 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r3G4iDCb299510
	for <qemu-devel@nongnu.org>; Tue, 16 Apr 2013 00:44:13 -0400
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r3G4iDQI010213
	for <qemu-devel@nongnu.org>; Tue, 16 Apr 2013 00:44:13 -0400
Message-ID: <516CD71C.1010707@linux.vnet.ibm.com>
Date: Tue, 16 Apr 2013 00:44:12 -0400
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1366080286-9288-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1366080286-9288-3-git-send-email-mrhines@linux.vnet.ibm.com>
	<516CC465.6090305@redhat.com>
In-Reply-To: <516CC465.6090305@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/8] rdma: new QEMUFileOps hooks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

On 04/15/2013 11:24 PM, Paolo Bonzini wrote:
> Il 16/04/2013 04:44, mrhines@linux.vnet.ibm.com ha scritto:
>> +void ram_control_load_hook(QEMUFile *f, uint32_t flags)
>> +{
>> +    int ret = 0;
>> +
>> +    if (f->ops->hook_ram_load) {
>> +        ret = f->ops->hook_ram_load(f, f->opaque, flags);
>> +        if (ret < 0) {
>> +            qemu_file_set_error(f, ret);
>> +        }
>> +    }
>> +}
> This must set an error if the hook is not implemented.
>
> Paolo
>

Good catch, thanks.