All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5][v4] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399
Date: Tue, 16 Apr 2013 10:19:51 +0530	[thread overview]
Message-ID: <516CD86F.6000105@freescale.com> (raw)
In-Reply-To: <516CD16B.6010902@freescale.com>

On 04/16/2013 09:49 AM, Prabhakar Kushwaha wrote:
> On 04/16/2013 03:11 AM, Scott Wood wrote:
>> On 04/15/2013 05:12:48 AM, Prabhakar Kushwaha wrote:
>>> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c 
>>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> index dacfdd1..439a873 100644
>>> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> @@ -25,7 +25,7 @@
>>>
>>>  DECLARE_GLOBAL_DATA_PTR;
>>>
>>> -#if defined(CONFIG_SYS_FSL_ERRATUM_IFC_A003399) && 
>>> !defined(CONFIG_SYS_RAMBOOT)
>>> +#ifdef CONFIG_A003399_NOR_WORKAROUND
>>
>> Won't this break bisectability since you don't define 
>> CONFIG_A003399_NOR_WORKAROUND until a later patch?
>>
>
> This workaround is only required for P1010. so for other SoC it should 
> not be defined.  For P1010 it is defined in P10101RDB.h
> also all patches of a patch set should be applied at once.
>
> may be I am unable to understand the question.
>

is it related to bisectability feature of git? in that case there can be 
2 possible solutions
a) change the patch set sequence
b) combine  patch. but changes are in arch/powerpc/ and boards files. 
will it be right to combine together?

Please suggest!!

Regards,
Prabhakar

  reply	other threads:[~2013-04-16  4:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 10:12 [U-Boot] [PATCH 1/5][v4] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399 Prabhakar Kushwaha
2013-04-15 21:41 ` Scott Wood
2013-04-16  4:19   ` Prabhakar Kushwaha
2013-04-16  4:49     ` Prabhakar Kushwaha [this message]
2013-04-16 17:05     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516CD86F.6000105@freescale.com \
    --to=prabhakar@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.