From: Haren Myneni <haren@linux.vnet.ibm.com>
To: Alistair Popple <alistair@popple.id.au>
Cc: sfr@canb.auug.org.au, mikey@neuling.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Fix audit crash due to save/restore PPR changes
Date: Mon, 15 Apr 2013 22:38:01 -0700 [thread overview]
Message-ID: <516CE3B9.6030901@linux.vnet.ibm.com> (raw)
In-Reply-To: <18949a6b246ced7268c2d2831f931f01.squirrel@mignight.com>
On 04/14/2013 06:44 PM, Alistair Popple wrote:
> The current mainline crashes when hitting userspace with the following:
>
> kernel BUG at /home/alistair/Source/linux-stable/kernel/auditsc.c:1769!
> cpu 0x1: Vector: 700 (Program Check) at [c000000023883a60]
> pc: c0000000001047a8: .__audit_syscall_entry+0x38/0x130
> lr: c00000000000ed64: .do_syscall_trace_enter+0xc4/0x270
> sp: c000000023883ce0
> msr: 8000000000029032
> current = 0xc000000023800000
> paca = 0xc00000000f080380 softe: 0 irq_happened: 0x01
> pid = 1629, comm = start_udev
> kernel BUG at /home/alistair/Source/linux-stable/kernel/auditsc.c:1769!
> enter ? for help
> [c000000023883d80] c00000000000ed64 .do_syscall_trace_enter+0xc4/0x270
> [c000000023883e30] c000000000009b08 syscall_dotrace+0xc/0x38
> --- Exception: c00 (System Call) at 0000008010ec50dc
>
> Bisecting found the following patch caused it:
>
> commit 44e9309f1f357794b7ae93d5f3e3e6f11d2b8a7f
> Author: Haren Myneni <haren@linux.vnet.ibm.com>
> powerpc: Implement PPR save/restore
>
> It was found this patch corrupted r9 when calling
> SET_DEFAULT_THREAD_PPR()
>
> Using r10 as a scratch register instead of r9 solved the problem.
Thanks for fixing. Sorry I missed it
Acked-by: Haren Myneni <haren@us.ibm.com>
>
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> Acked-by: Michael Neuling <mikey@neuling.org>
> ---
>
> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
> index 256c5bf..3acb1a0 100644
> --- a/arch/powerpc/kernel/entry_64.S
> +++ b/arch/powerpc/kernel/entry_64.S
> @@ -304,7 +304,7 @@ syscall_exit_work:
> subi r12,r12,TI_FLAGS
>
> 4: /* Anything else left to do? */
> - SET_DEFAULT_THREAD_PPR(r3, r9) /* Set thread.ppr = 3 */
> + SET_DEFAULT_THREAD_PPR(r3, r10) /* Set thread.ppr = 3 */
> andi. r0,r9,(_TIF_SYSCALL_T_OR_A|_TIF_SINGLESTEP)
> beq .ret_from_except_lite
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2013-04-16 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 1:44 [PATCH] powerpc: Fix audit crash due to save/restore PPR changes Alistair Popple
2013-04-16 5:38 ` Haren Myneni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516CE3B9.6030901@linux.vnet.ibm.com \
--to=haren@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.