From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URz51-0002nw-Q4 for qemu-devel@nongnu.org; Tue, 16 Apr 2013 02:09:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URz50-0001E5-Tl for qemu-devel@nongnu.org; Tue, 16 Apr 2013 02:09:23 -0400 Received: from mail-bk0-x233.google.com ([2a00:1450:4008:c01::233]:59681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URz50-0001Dx-Mt for qemu-devel@nongnu.org; Tue, 16 Apr 2013 02:09:22 -0400 Received: by mail-bk0-f51.google.com with SMTP id y8so60114bkt.24 for ; Mon, 15 Apr 2013 23:09:22 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <516CEB06.6080803@redhat.com> Date: Tue, 16 Apr 2013 08:09:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366080286-9288-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366080286-9288-6-git-send-email-mrhines@linux.vnet.ibm.com> <516CD851.7050705@redhat.com> In-Reply-To: <516CD851.7050705@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 5/8] rdma: core rdma logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 16/04/2013 06:49, Paolo Bonzini ha scritto: >> > + remote_ram_blocks.num_blocks = remote_ram_blocks.remote_area; >> > + remote_ram_blocks.block = (void *) (remote_ram_blocks.num_blocks + 1); > You cannot do this, it doesn't guarantee that remote_ram_blocks.block is > correctly aligned. Please use an extra dummy struct RDMARemoteBlock. > Actually you do not need to transmit num_blocks at all, do you? You can just use head->len / sizeof(struct RDMARemoteBlock). Then num_blocks can stop being a pointer, and remote_area can disappear too. Paolo