From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp07.in.ibm.com (e28smtp07.in.ibm.com [122.248.162.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e28smtp07.in.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 176532C0106 for ; Tue, 16 Apr 2013 17:59:53 +1000 (EST) Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Apr 2013 13:25:07 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id A26B5394005E for ; Tue, 16 Apr 2013 13:29:45 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3G7xdrs10944964 for ; Tue, 16 Apr 2013 13:29:39 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3G7xiOG015287 for ; Tue, 16 Apr 2013 17:59:45 +1000 Message-ID: <516D04EF.6030803@linux.vnet.ibm.com> Date: Tue, 16 Apr 2013 13:29:43 +0530 From: Aruna Balakrishnaiah MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [PATCH 4/8] Read/Write oops nvram partition via pstore References: <20130410071835.20150.56489.stgit@aruna-ThinkPad-T420> <20130410072303.20150.61382.stgit@aruna-ThinkPad-T420> <20130415075555.GE30156@concordia> <516CEDB4.9090005@linux.vnet.ibm.com> <1366096475.24994.50.camel@pasglop> In-Reply-To: <1366096475.24994.50.camel@pasglop> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: jkenisto@linux.vnet.ibm.com, mahesh@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 16 April 2013 12:44 PM, Benjamin Herrenschmidt wrote: > On Tue, 2013-04-16 at 11:50 +0530, Aruna Balakrishnaiah wrote: >> Sure. I will have one #ifdef for declarations and one for function >> definitions. > Declarations generally don't need #ifdef's Sorry by declarations I meant variable declarations (used by pstore) not function declarations. > Cheers, > Ben. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262Ab3DPH7x (ORCPT ); Tue, 16 Apr 2013 03:59:53 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:36159 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817Ab3DPH7w (ORCPT ); Tue, 16 Apr 2013 03:59:52 -0400 Message-ID: <516D04EF.6030803@linux.vnet.ibm.com> Date: Tue, 16 Apr 2013 13:29:43 +0530 From: Aruna Balakrishnaiah User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Benjamin Herrenschmidt CC: Michael Ellerman , linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org, jkenisto@linux.vnet.ibm.com, mahesh@linux.vnet.ibm.com, anton@samba.org Subject: Re: [PATCH 4/8] Read/Write oops nvram partition via pstore References: <20130410071835.20150.56489.stgit@aruna-ThinkPad-T420> <20130410072303.20150.61382.stgit@aruna-ThinkPad-T420> <20130415075555.GE30156@concordia> <516CEDB4.9090005@linux.vnet.ibm.com> <1366096475.24994.50.camel@pasglop> In-Reply-To: <1366096475.24994.50.camel@pasglop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13041607-2000-0000-0000-00000BBFB2D9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 April 2013 12:44 PM, Benjamin Herrenschmidt wrote: > On Tue, 2013-04-16 at 11:50 +0530, Aruna Balakrishnaiah wrote: >> Sure. I will have one #ifdef for declarations and one for function >> definitions. > Declarations generally don't need #ifdef's Sorry by declarations I meant variable declarations (used by pstore) not function declarations. > Cheers, > Ben. > >