Re: [RFC PATCH v2] can: sja1000: use common prefix for all sja1000 defines

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

On 04/13/2013 09:35 PM, Oliver Hartkopp wrote:
> This is a follow up patch to:
> 
>     f901b6b can: sja1000: fix define conflict on SH
> 
> That patch fixed a define conflict between the SH architecture and the sja1000
> driver, by addind a prefix to one macro only. This patch consistently renames
> the prefix of the SJA1000 controller registers from "REG_" to "SJA1000_".
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> 
> ---
> 
> Hello Marc,
> 
> to not miss the current net-next window, here's a well formatted patch for my
> REG_ rename proposal. It renames the formerly register defines from REG_ to
> SJA1000_ and leaves the content definitions of the registers as-is.
> This is because of all content definitions would have to be changed in 
> sja1000.h AND include/linux/can/platform/sja1000.h to have a consistent
> naming scheme.

Looks good, I've fixed the indention in
drivers/net/can/sja1000/sja1000.h. I'll send a pull request to David soon.

Thanks, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]