From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v4 1/2] libxl: postpone backend name resolution
Date: Tue, 16 Apr 2013 12:23:48 +0100 [thread overview]
Message-ID: <516D34C4.70703@eu.citrix.com> (raw)
In-Reply-To: <1366027867.4963.120.camel@zakaz.uk.xensource.com>
On 15/04/13 13:11, Ian Campbell wrote:
> On Fri, 2013-04-12 at 16:22 +0100, Daniel De Graaf wrote:
>> This adds a backend_domname field in libxl devices that contain a
>> backend_domid field, allowing either a domid or a domain name to be
>> specified in the configuration structures. The domain name is resolved
>> into a domain ID in the _setdefault function when adding the device.
>> This change allows the backend of the block devices to be specified
>> (which previously required passing the libxl_ctx down into the block
>> device parser), and will simplify specification of backend domains in
>> other users of libxl.
> Looks good to me (some minor comments below). Given that the initial
> version of this was posted ages ago I think this should be granted a
> freeze exception. George?
1. It seems like if there are any bugs they should be caught before the
release
2. Allowing disk backends to be specified seems like a very good feature
for 4.3; and it seems like if there is a bug it should be caught before
the release and fairly easy to fix.
So re the code freeze:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
next prev parent reply other threads:[~2013-04-16 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 15:22 [PATCH v4 1/2] libxl: postpone backend name resolution Daniel De Graaf
2013-04-12 15:22 ` [PATCH v4 2/2] libxl: properly initialize device structures Daniel De Graaf
2013-04-15 12:11 ` Ian Campbell
2013-04-17 15:01 ` Ian Campbell
2013-04-17 15:06 ` Daniel De Graaf
2013-04-15 12:11 ` [PATCH v4 1/2] libxl: postpone backend name resolution Ian Campbell
2013-04-15 14:29 ` Daniel De Graaf
2013-04-16 11:23 ` George Dunlap [this message]
2013-04-15 14:55 ` Roger Pau Monné
2013-04-15 14:59 ` Ian Campbell
2013-04-15 15:38 ` Ian Campbell
2013-04-15 15:03 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D34C4.70703@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.