All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"Tim (Xen.org)" <tim@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 6/9] xen: move VCPUOP_register_vcpu_info to common code
Date: Tue, 16 Apr 2013 13:51:20 +0100	[thread overview]
Message-ID: <516D4948.5070409@citrix.com> (raw)
In-Reply-To: <1364309252-26688-6-git-send-email-stefano.stabellini@eu.citrix.com>

On 03/26/2013 02:47 PM, Stefano Stabellini wrote:

> +int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned offset)
> +{
> +    struct domain *d = v->domain;
> +    void *mapping;
> +    vcpu_info_t *new_info;
> +    struct page_info *page;
> +    int i;
> +
> +    if ( offset > (PAGE_SIZE - sizeof(vcpu_info_t)) )
> +        return -EINVAL;
> +
> +    if ( v->vcpu_info_mfn != INVALID_MFN )
> +        return -EINVAL;
> +
> +    /* Run this command on yourself or on other offline VCPUS. */
> +    if ( (v != current) && !test_bit(_VPF_down, &v->pause_flags) )
> +        return -EINVAL;
> +
> +    page = get_page_from_gfn(d, gfn, NULL, P2M_ALLOC);

This patch doesn't compile on x86. get_page_from_gfn is missing.

Adding #include <asm/p2m.h> on top of the file (common/domain.c)
resolves the compilation error.

Julien

  reply	other threads:[~2013-04-16 12:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 14:46 [PATCH v2 0/9] xen/arm: guest SMP support Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 1/9] xen/arm: basic PSCI support, implement cpu_on Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 2/9] xen/arm: allocate secondaries dom0 vcpus Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 3/9] xen/arm: support for guest SGI Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 4/9] xen/arm: support vcpu_op hypercalls Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 5/9] xen/arm: implement map_domain_page_global and unmap_domain_page_global Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 6/9] xen: move VCPUOP_register_vcpu_info to common code Stefano Stabellini
2013-04-16 12:51   ` Julien Grall [this message]
2013-04-18 12:02     ` Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 7/9] xen/arm: send IPIs to inject irqs into guest vcpus running on different pcpus Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 8/9] xen/arm: start the vtimer Xen timers on the processor they should be running on Stefano Stabellini
2013-03-26 14:47 ` [PATCH v2 9/9] xen/arm: initialize virt_timer and phys_timer with the same values on all vcpus Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516D4948.5070409@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.