From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH V2 6/6] DT: MIPS: ralink: add MT7620A dts files
Date: Tue, 16 Apr 2013 16:59:01 +0400 [thread overview]
Message-ID: <516D4B15.406@cogentembedded.com> (raw)
In-Reply-To: <1366103562-21463-6-git-send-email-blogic@openwrt.org>
Hello.
On 16-04-2013 13:12, John Crispin wrote:
> Add a dtsi file for MT7620A SoC and a sample dts file.
> Signed-off-by: John Crispin <blogic@openwrt.org>
[...]
> diff --git a/arch/mips/ralink/dts/mt7620a.dtsi b/arch/mips/ralink/dts/mt7620a.dtsi
> new file mode 100644
> index 0000000..08bf24f
> --- /dev/null
> +++ b/arch/mips/ralink/dts/mt7620a.dtsi
> @@ -0,0 +1,58 @@
[...]
> + cpuintc: cpuintc@0 {
> + #address-cells = <0>;
Why? There's no subnodes.
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + compatible = "mti,cpu-interrupt-controller";
> + };
> +
> + palmbus@10000000 {
> + compatible = "palmbus";
> + reg = <0x10000000 0x200000>;
> + ranges = <0x0 0x10000000 0x1FFFFF>;
This line is indented with spaces. And the last cell should probably be
0x200000.
WBR, Sergei
next prev parent reply other threads:[~2013-04-16 13:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 9:12 [PATCH V2 1/6] DT: add vendor prefixes for Ralink John Crispin
2013-04-16 9:12 ` John Crispin
2013-04-16 9:12 ` [PATCH V2 2/6] DT: add documentation for the Ralink MIPS SoCs John Crispin
2013-04-16 9:12 ` John Crispin
2013-04-16 9:12 ` [PATCH V2 3/6] DT: MIPS: ralink: clean up RT3050 dtsi and dts file John Crispin
2013-04-16 9:12 ` [PATCH V2 4/6] DT: MIPS: ralink: add RT2880 dts files John Crispin
2013-04-16 9:12 ` [PATCH V2 5/6] DT: MIPS: ralink: add RT3883 " John Crispin
2013-04-16 9:12 ` John Crispin
2013-04-16 13:00 ` Sergei Shtylyov
2013-04-16 9:12 ` [PATCH V2 6/6] DT: MIPS: ralink: add MT7620A " John Crispin
2013-04-16 9:12 ` John Crispin
2013-04-16 12:59 ` Sergei Shtylyov [this message]
2013-04-18 12:50 ` [PATCH V2 1/6] DT: add vendor prefixes for Ralink Grant Likely
2013-04-18 12:50 ` Grant Likely
2013-04-18 12:46 ` John Crispin
2013-04-18 12:46 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D4B15.406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.