From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2 2/7] libxl: add new hotplug interface
 support to hotplug script callers
Date: Tue, 16 Apr 2013 16:42:51 +0200
Message-ID: <516D636B.7010500@citrix.com>
References: <1363607231-35228-1-git-send-email-roger.pau@citrix.com>
	<1363607231-35228-3-git-send-email-roger.pau@citrix.com>
	<20838.58346.97746.93989@mariner.uk.xensource.com>
	<516D3655.4060001@citrix.com>
	<1366113994.8399.171.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1366113994.8399.171.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 16/04/13 14:06, Ian Campbell wrote:
> On Tue, 2013-04-16 at 12:30 +0100, Roger Pau Monne wrote:
>> On 11/04/13 18:25, Ian Jackson wrote:
>>> Roger Pau Monne writes ("[Xen-devel] [PATCH v2 2/7] libxl: add new hotplug interface support to hotplug script callers"):
>>>> +The hotplug script should take special care in not storing arbitrary
>>>> +values in the following entries:
>>>> +
>>>> +HOTPLUG_PATH/version
>>>> +HOTPLUG_PATH/pdev
>>>
>>> Do we want to allow any scope for introducing new toolstack-reserved
>>> entries later ?
>>
>> Would you agree to say that the script is not able to use entries
>> beginning with libxl_*, so we can reserve that for later use?
> 
> Doesn't the toolstack have its own prefix, under which it could
> duplicate HOTPLUG_PATH if it wanted?
> 
> Or maybe there is more benefit to having all the hotplug info about a
> device in the same place to having things be nicely separated?

One solution would be to say that the hotplug script can only write to
the following entries:

HOTPLUG_PATH/version
HOTPLUG_PATH/pdev

And then provide the script with another path that could be used to
store whatever private entries the hotplug script needs:

PRIVATE_PATH

This would solve the problem of adding new toolstack-reserved entries
later in HOTPLUG_PATH.

The private path could for example be:

/local/domain/<local_domid>/libxl/private/vbd/<guest_domid>/<device_id>

Which is basically the same as HOTPLUG_PATH replacing "hotplug" with
"private".

>>
>> Also, if you could take a look at the rest of the series, I would like
>> to try to respin the series before the end of the week.
>>
>>> "... take special care not to store ..." would be correct grammar.
>>>
>>> Thanks,
>>> Ian.
>>>
>>
> 
>