From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US7c3-0006JU-72 for qemu-devel@nongnu.org; Tue, 16 Apr 2013 11:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US7c1-0003uC-Bs for qemu-devel@nongnu.org; Tue, 16 Apr 2013 11:16:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US7Jm-0003GO-CH for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:57:10 -0400 Message-ID: <516D669E.7000708@redhat.com> Date: Tue, 16 Apr 2013 08:56:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365851501-3037-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1365851501-3037-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1365851501-3037-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2POVNUWUOUTKTTUWHTMKL" Subject: Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2POVNUWUOUTKTTUWHTMKL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/13/2013 05:11 AM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction()i, except fail handling s/i,/,/ > label is changed from "delete_and_fail" to "fail". Other code such > as input parsing is not touched, to make it easier in review. >=20 > Signed-off-by: Wenchao Xia > --- > blockdev.c | 146 +++++++++++++++++++++++++++++++++-------------------= ------- > 1 files changed, 82 insertions(+), 64 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2POVNUWUOUTKTTUWHTMKL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbWaeAAoJEKeha0olJ0Nq0QYH/1OaJYuREneCWp++V0M/Hv9s /3pGtRiDL8U10+czciMRzx+niJwkO5jri6bDn8ri66DJHqiZDNEiwa5knXOAeR7r 3kVP+qtWrL98n6h2UwaSZk78GvJEkDs+1VL7b83ndgbSzaHagOomvriLh8znZGSb +K8RxxWTGnmA4+z8zSuVsmKpjreEwESD9MPwDqxdXck33uMzh+DyQlgVlcWToBi6 1CuSpfX4FsaptmngZtqM8qTfMfSFH0Wnyo280zb3PXy0dVTRzu+iRjKa5zJIm9u3 YlcJek7FZa6cnshQMj5FqP/vkL11lmCaoGGkzIfqsjolDMtIJuDIpXwRTBnrQ44= =anBM -----END PGP SIGNATURE----- ------enig2POVNUWUOUTKTTUWHTMKL--