All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: David Rientjes <rientjes@google.com>,
	Antti Palosaari <crope@iki.fi>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media <linux-media@vger.kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH -next] staging/media: fix go7007 dependencies and build
Date: Tue, 16 Apr 2013 08:33:22 -0700	[thread overview]
Message-ID: <516D6F42.7000709@infradead.org> (raw)
In-Reply-To: <20130416061243.22d06140@redhat.com>

From: Randy Dunlap <rdunlap@infradead.org>

VIDEO_GO7007 uses usb interfaces so it should depend on USB.
It also selects CYPRESS_FIRMWARE, which depends on USB.

Fixes build errors and a kconfig warning:

go7007-loader.c:(.text+0xcc7d0): undefined reference to `usb_get_dev'
go7007-loader.c:(.init.text+0x49f0): undefined reference to `usb_register_driver'
go7007-loader.c:(.exit.text+0x17ce): undefined reference to `usb_deregister'

warning: (DVB_USB_AZ6007 && VIDEO_GO7007) selects CYPRESS_FIRMWARE which has unmet direct dependencies (MEDIA_SUPPORT && USB)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/staging/media/go7007/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20130416.orig/drivers/staging/media/go7007/Kconfig
+++ linux-next-20130416/drivers/staging/media/go7007/Kconfig
@@ -1,7 +1,7 @@
 config VIDEO_GO7007
 	tristate "WIS GO7007 MPEG encoder support"
 	depends on VIDEO_DEV && I2C
-	depends on SND
+	depends on SND && USB
 	select VIDEOBUF2_VMALLOC
 	select VIDEO_TUNER
 	select CYPRESS_FIRMWARE

  reply	other threads:[~2013-04-16 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  7:43 linux-next: Tree for Apr 8 Stephen Rothwell
2013-04-08  7:43 ` Stephen Rothwell
2013-04-08 17:47 ` [PATCH -next] media: Randy Dunlap
2013-04-09 18:46   ` Antti Palosaari
2013-04-16  3:10     ` David Rientjes
2013-04-16  9:12       ` Mauro Carvalho Chehab
2013-04-16 15:33         ` Randy Dunlap [this message]
2013-04-10  8:51 ` linux-next: Tree for Apr 8 Geert Uytterhoeven
2013-04-10  8:53   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516D6F42.7000709@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=crope@iki.fi \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.